mirror of
https://github.com/github/codeql.git
synced 2026-06-30 09:05:28 +02:00
5b63b4957c
Mostly just adding `private import LegacyPointsTo`. Sometimes getting rid of other imports that are superceded by that module.
31 lines
709 B
Plaintext
31 lines
709 B
Plaintext
/**
|
|
* @name Module imports itself
|
|
* @description A module imports itself
|
|
* @kind problem
|
|
* @tags quality
|
|
* maintainability
|
|
* useless-code
|
|
* @problem.severity recommendation
|
|
* @sub-severity high
|
|
* @precision very-high
|
|
* @id py/import-own-module
|
|
*/
|
|
|
|
import python
|
|
private import LegacyPointsTo
|
|
|
|
predicate modules_imports_itself(ImportingStmt i, ModuleValue m) {
|
|
i.getEnclosingModule() = m.getScope() and
|
|
m =
|
|
max(string s, ModuleValue m_ |
|
|
s = i.getAnImportedModuleName() and
|
|
m_.importedAs(s)
|
|
|
|
|
m_ order by s.length()
|
|
)
|
|
}
|
|
|
|
from ImportingStmt i, ModuleValue m
|
|
where modules_imports_itself(i, m)
|
|
select i, "The module '" + m.getName() + "' imports itself."
|