mirror of
https://github.com/github/codeql.git
synced 2026-05-14 19:29:28 +02:00
fef08afff9
Moves the existing points-to predicates to the newly added class `ControlFlowNodeWithPointsTo` which resides in the `LegacyPointsTo` module. (Existing code that uses these predicates should import this module, and references to `ControlFlowNode` should be changed to `ControlFlowNodeWithPointsTo`.) Also updates all existing points-to based code to do just this.
28 lines
803 B
Plaintext
28 lines
803 B
Plaintext
/**
|
|
* @name Non-iterable used in for loop
|
|
* @description Using a non-iterable as the object in a 'for' loop causes a TypeError.
|
|
* @kind problem
|
|
* @tags quality
|
|
* reliability
|
|
* correctness
|
|
* @problem.severity error
|
|
* @sub-severity low
|
|
* @precision high
|
|
* @id py/non-iterable-in-for-loop
|
|
*/
|
|
|
|
import python
|
|
private import LegacyPointsTo
|
|
|
|
from For loop, ControlFlowNodeWithPointsTo iter, Value v, ClassValue t, ControlFlowNode origin
|
|
where
|
|
loop.getIter().getAFlowNode() = iter and
|
|
iter.pointsTo(_, v, origin) and
|
|
v.getClass() = t and
|
|
not t.isIterable() and
|
|
not t.failedInference(_) and
|
|
not v = Value::named("None") and
|
|
not t.isDescriptorType()
|
|
select loop, "This for-loop may attempt to iterate over a $@ of class $@.", origin,
|
|
"non-iterable instance", t, t.getName()
|