mirror of
https://github.com/github/codeql.git
synced 2025-12-17 01:03:14 +01:00
df3dc9677f
There were missing extractions from the Builtin (and other) modules. This was actually caused by two issues: * we did not visit all required modules, as for example the `Builtin` module does not appear as being imported by anybody (together with another mysterious `__Objc` module) * moreover the `Builtin` module works internally by only creating declarations on demand, and does not provide a list of its top level declarations. The first problem was solved by moving module collection to the actual visiting. This may mean we extract less modules, as we only extract the modules we actually use something from (recursively). This change can be reverted if we feel we need it. The second one was solved by explicitly listing the builtin symbols encountered during a normal extraction. This does mean this list needs to be kept up to date.