mirror of
https://github.com/github/codeql.git
synced 2025-12-28 06:36:33 +01:00
3fe715abb6
Without backticks, the text UNDERSCORE UNDERSCORE eq UNDERSCORE UNDERSCORE would be considered to make things bold in our markdown output, making the query info look strange. Example https://codeql.github.com/codeql-query-help/python/py-slots-in-old-style-class/
35 lines
1.1 KiB
Plaintext
35 lines
1.1 KiB
Plaintext
/**
|
|
* @name Undefined class attribute
|
|
* @description Accessing an attribute of `self` that is not initialized anywhere in the class in the `__init__` method may cause an AttributeError at runtime
|
|
* @kind problem
|
|
* @tags reliability
|
|
* correctness
|
|
* @problem.severity error
|
|
* @sub-severity low
|
|
* @precision low
|
|
* @id py/undefined-attribute
|
|
*/
|
|
|
|
import python
|
|
import semmle.python.SelfAttribute
|
|
import ClassAttributes
|
|
|
|
predicate undefined_class_attribute(SelfAttributeRead a, CheckClass c, int line, string name) {
|
|
name = a.getName() and
|
|
not c.sometimesDefines(name) and
|
|
c.interestingUndefined(a) and
|
|
line = a.getLocation().getStartLine() and
|
|
not attribute_assigned_in_method(c.getAMethodCalledFromInit(), name)
|
|
}
|
|
|
|
predicate report_undefined_class_attribute(Attribute a, ClassObject c, string name) {
|
|
exists(int line |
|
|
undefined_class_attribute(a, c, line, name) and
|
|
line = min(int x | undefined_class_attribute(_, c, x, name))
|
|
)
|
|
}
|
|
|
|
from Attribute a, ClassObject c, string name
|
|
where report_undefined_class_attribute(a, c, name)
|
|
select a, "Attribute '" + name + "' is not defined in either the class body or in any method"
|