mirror of
https://github.com/github/codeql.git
synced 2026-01-12 14:10:21 +01:00
4ef5c9af62
Some files that will change in #1736 have been spared. ./build -j4 target/jars/qlformat find ql/cpp/ql -name "*.ql" -print0 | xargs -0 target/jars/qlformat --input find ql/cpp/ql -name "*.qll" -print0 | xargs -0 target/jars/qlformat --input (cd ql && git checkout 'cpp/ql/src/semmle/code/cpp/ir/implementation/**/*SSA*.qll') buildutils-internal/scripts/pr-checks/sync-identical-files.py --latest
39 lines
1.2 KiB
Plaintext
39 lines
1.2 KiB
Plaintext
/**
|
|
* @name Duplicate function
|
|
* @description There is another identical implementation of this function. Extract the code to a common file or superclass or delegate to improve sharing.
|
|
* @kind problem
|
|
* @id cpp/duplicate-function
|
|
* @problem.severity recommendation
|
|
* @precision medium
|
|
* @tags testability
|
|
* maintainability
|
|
* duplicate-code
|
|
* non-attributable
|
|
*/
|
|
|
|
import cpp
|
|
import CodeDuplication
|
|
|
|
predicate relevant(FunctionDeclarationEntry m) {
|
|
exists(Location loc |
|
|
loc = m.getBlock().getLocation() and
|
|
(
|
|
loc.getStartLine() + 5 < loc.getEndLine() and not m.getName().matches("get%")
|
|
or
|
|
loc.getStartLine() + 10 < loc.getEndLine()
|
|
)
|
|
)
|
|
}
|
|
|
|
from FunctionDeclarationEntry m, FunctionDeclarationEntry other
|
|
where
|
|
duplicateMethod(m, other) and
|
|
relevant(m) and
|
|
not m.getFunction().isConstructedFrom(_) and
|
|
not other.getFunction().isConstructedFrom(_) and
|
|
not fileLevelDuplication(m.getFile(), other.getFile()) and
|
|
not classLevelDuplication(m.getFunction().getDeclaringType(),
|
|
other.getFunction().getDeclaringType())
|
|
select m, "Function " + m.getName() + " is duplicated at $@.", other,
|
|
other.getFile().getBaseName() + ":" + other.getLocation().getStartLine().toString()
|