mirror of
https://github.com/github/codeql.git
synced 2026-05-01 19:55:15 +02:00
11c71fdd18
This commit removes SSA nodes from the data flow graph. Specifically, for a definition and use such as ```python x = expr y = x + 2 ``` we used to have flow from `expr` to an SSA variable representing x and from that SSA variable to the use of `x` in the definition of `y`. Now we instead have flow from `expr` to the control flow node for `x` at line 1 and from there to the control flow node for `x` at line 2. Specific changes: - `EssaNode` from the data flow layer no longer exists. - Several glue steps between `EssaNode`s and `CfgNode`s have been deleted. - Entry nodes are now admitted as `CfgNodes` in the data flow layer (they were filtered out before). - Entry nodes now have a new `toString` taking into account that the module name may be ambigous. - Some tests have been rewritten to accomodate the changes, but only `python/ql/test/experimental/dataflow/basic/maximalFlowsConfig.qll` should have semantic changes. - Comments have been updated - Test output has been updated, but apart from `python/ql/test/experimental/dataflow/basic/maximalFlows.expected` only `python/ql/test/experimental/dataflow/typetracking-summaries/summaries.py` should have a semantic change. This is a bonus fix, probably meaning that something was never connected up correctly.
Dataflow, points-to, call-graph and type-inference tests.
Since dataflow, points-to, call-graph and type-inference are all interlinked it makes sense to test them together.
The test code.
The test code is all under the code/ subdirectory and all test files are named \w_name, supporting
files do have an underscore as their second character.
This allows tests to be applied to a subset of the test data and test/data combinations to be turned on/off easily for debugging.
Be aware that here are two __init__.py, so the results are interleaved.