mirror of
https://github.com/github/codeql.git
synced 2025-12-25 13:16:33 +01:00
a803120414
These queries are currently run by default, but don't have their results displayed. Looking through results on LGTM.com, they are either false positives (e.g., `BitwiseSignCheck` which flags many perfectly harmless operations and `CompareIdenticalValues` which mostly flags NaN checks) or harmless results that developers are unlikely to care about (e.g., `EmptyArrayInit` or `MisspelledIdentifier`). With this PR, the only queries that are still run but not displayed are security queries, where different considerations may apply.
23 lines
655 B
Plaintext
23 lines
655 B
Plaintext
/**
|
|
* @name Function with too many parameters
|
|
* @description Functions with many parameters are hard to read and hard to use.
|
|
* @kind problem
|
|
* @problem.severity recommendation
|
|
* @id js/too-many-parameters
|
|
* @tags testability
|
|
* readability
|
|
* @precision low
|
|
*/
|
|
|
|
import javascript
|
|
import semmle.javascript.RestrictedLocations
|
|
|
|
from Function f
|
|
where
|
|
not f.inExternsFile() and
|
|
f.getNumParameter() > 7 and
|
|
// exclude AMD modules
|
|
not exists(AmdModuleDefinition m | f = m.getFactoryNode().(DataFlow::FunctionNode).getAstNode())
|
|
select f.(FirstLineOf),
|
|
capitalize(f.describe()) + " has too many parameters (" + f.getNumParameter() + ")."
|