Files
codeql/java/ql/src/Architecture/Refactoring Opportunities/FeatureEnvy.java
2018-08-30 10:48:05 +01:00

22 lines
417 B
Java

// Before refactoring:
class Item { .. }
class Basket {
// ..
float getTotalPrice(Item i) {
float price = i.getPrice() + i.getTax();
if (i.isOnSale())
price = price - i.getSaleDiscount() * price;
return price;
}
}
// After refactoring:
class Item {
// ..
float getTotalPrice() {
float price = getPrice() + getTax();
if (isOnSale())
price = price - getSaleDiscount() * price;
return price;
}
}