mirror of
https://github.com/github/codeql.git
synced 2026-06-25 22:57:01 +02:00
5081d8171e
Flips the Python dataflow trunk from the legacy CFG (semmle/python/Flow.qll) and legacy ESSA SSA (semmle/python/essa/*) to the new shared CFG facade (semmle.python.controlflow.internal.Cfg) and the new SSA adapter (semmle.python.dataflow.new.internal.SsaImpl), both introduced additively in the preceding PRs in this stack. This is the trunk-flip equivalent of the original draft PR #21894 (kept around as documentation), rebased on top of the four preparatory PRs: P1: Remove AstNode.getAFlowNode() and rewrite callers (#21919). P2: Qualify Flow.qll's AST references with Py:: prefix (#21920). P3: Add new shared-CFG-backed control flow graph (#21921). P4: Add new shared-SSA-backed SSA adapter (#21923). The Python dataflow library (semmle/python/dataflow/new/) now imports the new CFG facade and SSA adapter. All CFG-typed predicates (ControlFlowNode, CallNode, BasicBlock, NameNode, AttrNode, ...) are qualified with the Cfg:: prefix; SSA references switch from EssaVariable/EssaDefinition to SsaImpl::Definition/SourceVariable. GuardNode is redesigned to use the new CFG's outcome-node model (isAfterTrue / isAfterFalse) instead of the legacy ConditionBlock + flipped indirection. Only BarrierGuard<...> is preserved as public API. Framework files (Bottle, FastApi, Django, Tornado, Pyramid, Stdlib, ...) are updated to take CFG nodes from the new facade. A handful of dataflow consistency tweaks for the new CFG: - Augmented-assignment targets are treated as both load and store. - 'from X import *' produces uncertain SSA writes for unknown names. - CFG nodes are canonicalised so dataflow does not see equivalent pre/post-order pairs as distinct nodes. Two AST tweaks for the new CFG: - AstNodeImpl: omit PEP 695 type-parameter names from FunctionDefExpr / ClassDefExpr children. - ImportResolution: drop the legacy essa import. Test churn (~175 files): reblessed library- and query-test .expected files reflect slightly different CFG granularity, different toString output, and a handful of true alert deltas in security queries. Verification: all 367 lib + src + consistency-queries compile clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
36 lines
2.8 KiB
Plaintext
36 lines
2.8 KiB
Plaintext
#select
|
|
| test.py:16:16:16:37 | Attribute() | test.py:16:16:16:37 | Attribute() | test.py:16:16:16:37 | Attribute() | $@ flows to this location and may be exposed to an external user. | test.py:16:16:16:37 | Attribute() | Stack trace information |
|
|
| test.py:24:16:24:16 | e | test.py:23:25:23:25 | e | test.py:24:16:24:16 | e | $@ flows to this location and may be exposed to an external user. | test.py:23:25:23:25 | e | Stack trace information |
|
|
| test.py:32:16:32:30 | Attribute | test.py:31:25:31:25 | e | test.py:32:16:32:30 | Attribute | $@ flows to this location and may be exposed to an external user. | test.py:31:25:31:25 | e | Stack trace information |
|
|
| test.py:50:16:50:32 | format_error() | test.py:49:15:49:36 | Attribute() | test.py:50:16:50:32 | format_error() | $@ flows to this location and may be exposed to an external user. | test.py:49:15:49:36 | Attribute() | Stack trace information |
|
|
| test.py:66:24:66:40 | Dict | test.py:65:25:65:25 | e | test.py:66:24:66:40 | Dict | $@ flows to this location and may be exposed to an external user. | test.py:65:25:65:25 | e | Stack trace information |
|
|
edges
|
|
| test.py:23:25:23:25 | e | test.py:24:16:24:16 | e | provenance | |
|
|
| test.py:31:25:31:25 | e | test.py:32:16:32:16 | e | provenance | |
|
|
| test.py:32:16:32:16 | e | test.py:32:16:32:30 | Attribute | provenance | Config |
|
|
| test.py:49:9:49:11 | err | test.py:50:29:50:31 | err | provenance | |
|
|
| test.py:49:15:49:36 | Attribute() | test.py:49:9:49:11 | err | provenance | |
|
|
| test.py:50:29:50:31 | err | test.py:50:16:50:32 | format_error() | provenance | |
|
|
| test.py:50:29:50:31 | err | test.py:52:18:52:20 | msg | provenance | |
|
|
| test.py:52:18:52:20 | msg | test.py:53:12:53:27 | BinaryExpr | provenance | |
|
|
| test.py:65:25:65:25 | e | test.py:66:34:66:39 | str() | provenance | |
|
|
| test.py:66:34:66:39 | str() | test.py:66:24:66:40 | Dict | provenance | |
|
|
nodes
|
|
| test.py:16:16:16:37 | Attribute() | semmle.label | Attribute() |
|
|
| test.py:23:25:23:25 | e | semmle.label | e |
|
|
| test.py:24:16:24:16 | e | semmle.label | e |
|
|
| test.py:31:25:31:25 | e | semmle.label | e |
|
|
| test.py:32:16:32:16 | e | semmle.label | e |
|
|
| test.py:32:16:32:30 | Attribute | semmle.label | Attribute |
|
|
| test.py:49:9:49:11 | err | semmle.label | err |
|
|
| test.py:49:15:49:36 | Attribute() | semmle.label | Attribute() |
|
|
| test.py:50:16:50:32 | format_error() | semmle.label | format_error() |
|
|
| test.py:50:29:50:31 | err | semmle.label | err |
|
|
| test.py:52:18:52:20 | msg | semmle.label | msg |
|
|
| test.py:53:12:53:27 | BinaryExpr | semmle.label | BinaryExpr |
|
|
| test.py:65:25:65:25 | e | semmle.label | e |
|
|
| test.py:66:24:66:40 | Dict | semmle.label | Dict |
|
|
| test.py:66:34:66:39 | str() | semmle.label | str() |
|
|
subpaths
|
|
| test.py:50:29:50:31 | err | test.py:52:18:52:20 | msg | test.py:53:12:53:27 | BinaryExpr | test.py:50:16:50:32 | format_error() |
|