Jonas Jensen 76ff250593 C++: Don't repeat work in BrokenCryptoAlgorithm.ql ...

The main source of slowness in `BrokenCryptoAlgorithm.ql` was that the
regexp on function (macro) names was evaluated once per call
(invocation) instead of once per name. Factoring out separate predicates
for the problematic functions (macros) fixes this.

On https://github.com/ericniebler/range-v3, this change reduces the run
time of the two slowest predicates from

    BrokenCryptoAlgorithm::InsecureMacroSpec#class#f .... 35.1s
    BrokenCryptoAlgorithm::InsecureFunctionCall#class#f . 12.8s

to

    BrokenCryptoAlgorithm::getAnInsecureFunction#f . 1.2s
    BrokenCryptoAlgorithm::getAnInsecureMacro#f .... 12ms

2019-03-18 12:01:37 +01:00

..

src

C++: Don't repeat work in BrokenCryptoAlgorithm.ql

2019-03-18 12:01:37 +01:00

test

Merge pull request #1033 from geoffw0/newdelete-perf

2019-03-05 12:52:59 +00:00