mirror of
https://github.com/github/codeql.git
synced 2025-12-19 18:33:16 +01:00
11c71fdd18
This commit removes SSA nodes from the data flow graph. Specifically, for a definition and use such as ```python x = expr y = x + 2 ``` we used to have flow from `expr` to an SSA variable representing x and from that SSA variable to the use of `x` in the definition of `y`. Now we instead have flow from `expr` to the control flow node for `x` at line 1 and from there to the control flow node for `x` at line 2. Specific changes: - `EssaNode` from the data flow layer no longer exists. - Several glue steps between `EssaNode`s and `CfgNode`s have been deleted. - Entry nodes are now admitted as `CfgNodes` in the data flow layer (they were filtered out before). - Entry nodes now have a new `toString` taking into account that the module name may be ambigous. - Some tests have been rewritten to accomodate the changes, but only `python/ql/test/experimental/dataflow/basic/maximalFlowsConfig.qll` should have semantic changes. - Comments have been updated - Test output has been updated, but apart from `python/ql/test/experimental/dataflow/basic/maximalFlows.expected` only `python/ql/test/experimental/dataflow/typetracking-summaries/summaries.py` should have a semantic change. This is a bonus fix, probably meaning that something was never connected up correctly.
43 lines
2.3 KiB
Python
43 lines
2.3 KiB
Python
import sys #$ importTimeFlow="ImportExpr -> sys"
|
|
import os #$ importTimeFlow="ImportExpr -> os"
|
|
|
|
sys.path.append(os.path.dirname(os.path.dirname((__file__))))
|
|
from testlib import expects #$ importTimeFlow="ImportMember -> expects"
|
|
|
|
# These are defined so that we can evaluate the test code.
|
|
NONSOURCE = "not a source" #$ importTimeFlow="'not a source' -> NONSOURCE"
|
|
SOURCE = "source" #$ importTimeFlow="'source' -> SOURCE"
|
|
|
|
|
|
def is_source(x): #$ importTimeFlow="FunctionExpr -> is_source"
|
|
return x == "source" or x == b"source" or x == 42 or x == 42.0 or x == 42j
|
|
|
|
|
|
def SINK(x): #$ importTimeFlow="FunctionExpr -> SINK"
|
|
if is_source(x): #$ runtimeFlow="ModuleVariableNode in Module multiphase for is_source, l:-17 -> is_source"
|
|
print("OK") #$ runtimeFlow="ModuleVariableNode in Module multiphase for print, l:-18 -> print"
|
|
else:
|
|
print("Unexpected flow", x) #$ runtimeFlow="ModuleVariableNode in Module multiphase for print, l:-20 -> print"
|
|
|
|
|
|
def SINK_F(x): #$ importTimeFlow="FunctionExpr -> SINK_F"
|
|
if is_source(x): #$ runtimeFlow="ModuleVariableNode in Module multiphase for is_source, l:-24 -> is_source"
|
|
print("Unexpected flow", x) #$ runtimeFlow="ModuleVariableNode in Module multiphase for print, l:-25 -> print"
|
|
else:
|
|
print("OK") #$ runtimeFlow="ModuleVariableNode in Module multiphase for print, l:-27 -> print"
|
|
|
|
def set_foo(): #$ importTimeFlow="FunctionExpr -> set_foo"
|
|
global foo
|
|
foo = SOURCE #$ runtimeFlow="ModuleVariableNode in Module multiphase for SOURCE, l:-31 -> SOURCE" # missing final definition of foo
|
|
|
|
foo = NONSOURCE #$ importTimeFlow="NONSOURCE -> foo"
|
|
set_foo()
|
|
|
|
@expects(2)
|
|
def test_phases(): #$ importTimeFlow="expects(..)(..), l:-1 -> test_phases"
|
|
global foo
|
|
SINK(foo) #$ runtimeFlow="ModuleVariableNode in Module multiphase for SINK, l:-39 -> SINK" runtimeFlow="ModuleVariableNode in Module multiphase for foo, l:-39 -> foo"
|
|
foo = NONSOURCE #$ runtimeFlow="ModuleVariableNode in Module multiphase for NONSOURCE, l:-40 -> NONSOURCE"
|
|
set_foo() #$ runtimeFlow="ModuleVariableNode in Module multiphase for set_foo, l:-41 -> set_foo"
|
|
SINK(foo) #$ runtimeFlow="ModuleVariableNode in Module multiphase for SINK, l:-42 -> SINK" runtimeFlow="ModuleVariableNode in Module multiphase for foo, l:-42 -> foo"
|