mirror of
https://github.com/github/codeql.git
synced 2026-06-09 06:58:50 +02:00
Flips the Python dataflow trunk from the legacy CFG (semmle/python/Flow.qll) and legacy ESSA SSA (semmle/python/essa/*) to the new shared CFG facade (semmle.python.controlflow.internal.Cfg) and the new SSA adapter (semmle.python.dataflow.new.internal.SsaImpl), both introduced additively in the preceding PRs in this stack. This is the trunk-flip equivalent of the original draft PR #21894 (kept around as documentation), rebased on top of the four preparatory PRs: P1: Remove AstNode.getAFlowNode() and rewrite callers (#21919). P2: Qualify Flow.qll's AST references with Py:: prefix (#21920). P3: Add new shared-CFG-backed control flow graph (#21921). P4: Add new shared-SSA-backed SSA adapter (#21923). The Python dataflow library (semmle/python/dataflow/new/) now imports the new CFG facade and SSA adapter. All CFG-typed predicates (ControlFlowNode, CallNode, BasicBlock, NameNode, AttrNode, ...) are qualified with the Cfg:: prefix; SSA references switch from EssaVariable/EssaDefinition to SsaImpl::Definition/SourceVariable. GuardNode is redesigned to use the new CFG's outcome-node model (isAfterTrue / isAfterFalse) instead of the legacy ConditionBlock + flipped indirection. Only BarrierGuard<...> is preserved as public API. Framework files (Bottle, FastApi, Django, Tornado, Pyramid, Stdlib, ...) are updated to take CFG nodes from the new facade. A handful of dataflow consistency tweaks for the new CFG: - Augmented-assignment targets are treated as both load and store. - 'from X import *' produces uncertain SSA writes for unknown names. - CFG nodes are canonicalised so dataflow does not see equivalent pre/post-order pairs as distinct nodes. Two AST tweaks for the new CFG: - AstNodeImpl: omit PEP 695 type-parameter names from FunctionDefExpr / ClassDefExpr children. - ImportResolution: drop the legacy essa import. Test churn (~175 files): reblessed library- and query-test .expected files reflect slightly different CFG granularity, different toString output, and a handful of true alert deltas in security queries. Verification: all 367 lib + src + consistency-queries compile clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
192 lines
6.4 KiB
Plaintext
192 lines
6.4 KiB
Plaintext
/**
|
|
* Provides classes modeling security-relevant aspects of the `bottle` PyPI package.
|
|
* See https://bottlepy.org/docs/dev/.
|
|
*/
|
|
|
|
private import python
|
|
private import semmle.python.controlflow.internal.Cfg as Cfg
|
|
private import semmle.python.Concepts
|
|
private import semmle.python.ApiGraphs
|
|
private import semmle.python.dataflow.new.RemoteFlowSources
|
|
private import semmle.python.frameworks.internal.InstanceTaintStepsHelper
|
|
private import semmle.python.frameworks.Stdlib
|
|
|
|
/**
|
|
* INTERNAL: Do not use.
|
|
*
|
|
* Provides models for the `bottle` PyPI package.
|
|
* See https://bottlepy.org/docs/dev/.
|
|
*/
|
|
module Bottle {
|
|
/** Gets a reference to the `bottle` module. */
|
|
API::Node bottle() { result = API::moduleImport("bottle") }
|
|
|
|
/** Provides models for the `bottle` module. */
|
|
module BottleModule {
|
|
/**
|
|
* Provides models for Bottle applications.
|
|
*/
|
|
module App {
|
|
/** Gets a reference to a Bottle application (an instance of `bottle.Bottle`) */
|
|
API::Node app() { result = bottle().getMember(["Bottle", "app"]).getReturn() }
|
|
}
|
|
|
|
/** Provides models for functions that are possible "views" */
|
|
module View {
|
|
/**
|
|
* A Bottle view callable, that handles incoming requests.
|
|
*/
|
|
class ViewCallable extends Function {
|
|
ViewCallable() { this = any(BottleRouteSetup rs).getARequestHandler() }
|
|
}
|
|
|
|
/** Get methods that represent a route in Bottle */
|
|
string routeMethods() { result = ["route", "get", "post", "put", "delete", "patch"] }
|
|
|
|
private class BottleRouteSetup extends Http::Server::RouteSetup::Range, DataFlow::CallCfgNode {
|
|
BottleRouteSetup() {
|
|
this =
|
|
[
|
|
App::app().getMember(routeMethods()).getACall(),
|
|
bottle().getMember(routeMethods()).getACall()
|
|
]
|
|
}
|
|
|
|
override DataFlow::Node getUrlPatternArg() {
|
|
result in [this.getArg(0), this.getArgByName("route")]
|
|
}
|
|
|
|
override string getFramework() { result = "Bottle" }
|
|
|
|
override Parameter getARoutedParameter() { none() }
|
|
|
|
override Function getARequestHandler() { node.getNode() = result.getADecorator() }
|
|
}
|
|
}
|
|
|
|
/** Provides models for the `bottle.response` module */
|
|
module Response {
|
|
/** Gets a reference to the `bottle.response` module or instantiation of Bottle Response class. */
|
|
API::Node response() {
|
|
result = [bottle().getMember("response"), bottle().getMember("Response").getReturn()]
|
|
}
|
|
|
|
/** A response returned by a view callable. */
|
|
class BottleReturnResponse extends Http::Server::HttpResponse::Range {
|
|
BottleReturnResponse() {
|
|
exists(Return ret |
|
|
ret.getScope() = any(View::ViewCallable vc) and
|
|
this.asCfgNode().getNode() = ret.getValue()
|
|
)
|
|
}
|
|
|
|
override DataFlow::Node getBody() { result = this }
|
|
|
|
override DataFlow::Node getMimetypeOrContentTypeArg() { none() }
|
|
|
|
override string getMimetypeDefault() { result = "text/html" }
|
|
}
|
|
|
|
/**
|
|
* A call to the `bottle.BaseResponse.set_header` or `bottle.BaseResponse.add_header` method.
|
|
*
|
|
* See https://bottlepy.org/docs/dev/api.html#bottle.BaseResponse.set_header
|
|
*/
|
|
class BottleResponseHandlerSetHeaderCall extends Http::Server::ResponseHeaderWrite::Range,
|
|
DataFlow::MethodCallNode
|
|
{
|
|
BottleResponseHandlerSetHeaderCall() {
|
|
this = response().getMember(["set_header", "add_header"]).getACall()
|
|
}
|
|
|
|
override DataFlow::Node getNameArg() {
|
|
result in [this.getArg(0), this.getArgByName("name")]
|
|
}
|
|
|
|
override DataFlow::Node getValueArg() {
|
|
result in [this.getArg(1), this.getArgByName("value")]
|
|
}
|
|
|
|
override predicate nameAllowsNewline() { none() }
|
|
|
|
override predicate valueAllowsNewline() { none() }
|
|
}
|
|
}
|
|
|
|
/** Provides models for the `bottle.request` module */
|
|
module Request {
|
|
/** Gets a reference to the `bottle.request` module. */
|
|
API::Node request() { result = bottle().getMember("request") }
|
|
|
|
private class Request extends RemoteFlowSource::Range {
|
|
Request() { this = request().asSource() }
|
|
|
|
override string getSourceType() { result = "bottle.request" }
|
|
}
|
|
|
|
/**
|
|
* Taint propagation for `bottle.request`.
|
|
*
|
|
* See https://bottlepy.org/docs/dev/api.html#bottle.request
|
|
*/
|
|
private class InstanceTaintSteps extends InstanceTaintStepsHelper {
|
|
InstanceTaintSteps() { this = "bottle.request" }
|
|
|
|
override DataFlow::Node getInstance() { result = request().getAValueReachableFromSource() }
|
|
|
|
override string getAttributeName() {
|
|
result in [
|
|
"headers", "query", "forms", "params", "json", "url", "body", "fullpath",
|
|
"query_string"
|
|
]
|
|
}
|
|
|
|
override string getMethodName() { none() }
|
|
|
|
override string getAsyncMethodName() { none() }
|
|
}
|
|
}
|
|
|
|
/** Provides models for the `bottle.headers` module */
|
|
module Headers {
|
|
/** Gets a reference to the `bottle.headers` module. */
|
|
API::Node headers() { result = bottle().getMember("response").getMember("headers") }
|
|
|
|
/** A dict-like write to a response header. */
|
|
class HeaderWriteSubscript extends Http::Server::ResponseHeaderWrite::Range, DataFlow::Node {
|
|
DataFlow::Node name;
|
|
DataFlow::Node value;
|
|
|
|
HeaderWriteSubscript() {
|
|
exists(Cfg::SubscriptNode subscript |
|
|
this.asCfgNode() = subscript and
|
|
value.asCfgNode() = subscript.(Cfg::DefinitionNode).getValue() and
|
|
name.asCfgNode() = subscript.getIndex() and
|
|
subscript.getObject() = headers().asSource().asCfgNode()
|
|
)
|
|
}
|
|
|
|
override DataFlow::Node getNameArg() { result = name }
|
|
|
|
override DataFlow::Node getValueArg() { result = value }
|
|
|
|
override predicate nameAllowsNewline() { none() }
|
|
|
|
override predicate valueAllowsNewline() { none() }
|
|
}
|
|
}
|
|
|
|
/** Provides models for functions that construct templates. */
|
|
module Templates {
|
|
/** A call to `bottle.template`or `bottle.SimpleTemplate`. */
|
|
private class BottleTemplateConstruction extends TemplateConstruction::Range, API::CallNode {
|
|
BottleTemplateConstruction() {
|
|
this = API::moduleImport("bottle").getMember(["template", "SimpleTemplate"]).getACall()
|
|
}
|
|
|
|
override DataFlow::Node getSourceArg() { result = this.getArg(0) }
|
|
}
|
|
}
|
|
}
|
|
}
|