mirror of
https://github.com/github/codeql.git
synced 2025-12-16 16:53:25 +01:00
69b87a63b8
This diagnostic was introduced by https://github.com/github/codeql/pull/15979. However in the meantime the Go team [has backtracked](https://github.com/golang/go/issues/62278#issuecomment-2062002018) on their decision, which leads to confusing alerts for user (e.g. https://github.com/github/codeql-action/issues/2868). Even using Go toolchains from 1.21 to 1.22 we weren't immediately able to reproduce the problem that this diagnostics was meant to guard against. Therefore it was deemed simpler to just remove it. _En passant_ the `Makefile` now accepts `rtjo` not being set.
73 lines
2.9 KiB
Makefile
73 lines
2.9 KiB
Makefile
# On Windows, make's path resolution algorithm is incorrect. It picks up a bazel.exe in PATH that's
|
|
# after a bazel binary. In particular, on actions, the non-exe binary is a bazelisk instance, whereas
|
|
# bazel.exe is a bazel installation.
|
|
# This means we pick up the wrong bazel version, and if the differences between the bazel we want
|
|
# and that we actually get are too big, the build fails on CI.
|
|
BAZEL := $(shell bash -c "which bazel")
|
|
|
|
rtjo ?= none
|
|
|
|
all: gen extractor
|
|
|
|
EXTRACTOR_PACK_OUT = extractor-pack
|
|
|
|
.PHONY: extractor gen clean autoformat check-formatting
|
|
|
|
clean:
|
|
rm -rf $(EXTRACTOR_PACK_OUT) build/stats build/testdb
|
|
|
|
autoformat:
|
|
find ql -iregex '.*\.qll?' -print0 | xargs -0 codeql query format -qq -i
|
|
find . -path '**/vendor' -prune -or -type f -iname '*.go' ! -empty -print0 | xargs -0 grep -L "//\s*autoformat-ignore" | xargs gofmt -w
|
|
|
|
check-formatting:
|
|
@output=$$(find . -path '**/vendor' -prune -or -type f -iname '*.go' ! -empty -print0 | xargs -0 grep -L "//\s*autoformat-ignore" | xargs gofmt -l 2>&1); \
|
|
if [ -n "$$output" ]; then \
|
|
echo "The following files need to be reformatted using gofmt or have compilation errors:"; \
|
|
echo "$$output"; \
|
|
fi; \
|
|
test -z "$$output"
|
|
|
|
ifeq ($(QHELP_OUT_DIR),)
|
|
# If not otherwise specified, compile qhelp to markdown in place
|
|
QHELP_OUT_DIR := ql/src
|
|
endif
|
|
|
|
qhelp-to-markdown:
|
|
scripts/qhelp-to-markdown.sh ql/src "$(QHELP_OUT_DIR)"
|
|
|
|
extractor:
|
|
$(BAZEL) run :go-installer
|
|
|
|
gen:
|
|
$(BAZEL) run :gen
|
|
|
|
build/stats/src.stamp:
|
|
mkdir -p $(@D)/src
|
|
git clone 'https://github.com/golang/tools' $(@D)/src
|
|
git -C $(@D)/src checkout 9b52d559c609 -q
|
|
touch $@
|
|
|
|
ql/lib/go.dbscheme.stats: ql/lib/go.dbscheme build/stats/src.stamp extractor
|
|
rm -rf build/stats/database
|
|
codeql database create -l go -s build/stats/src -j4 --search-path . build/stats/database
|
|
codeql dataset measure -o $@ build/stats/database/db-go
|
|
|
|
test: all build/testdb/check-upgrade-path
|
|
codeql test run -j0 ql/test --search-path .. --consistency-queries ql/test/consistency --compilation-cache=$(cache) --dynamic-join-order-mode=$(rtjo)
|
|
# use GOOS=linux because GOOS=darwin GOARCH=386 is no longer supported
|
|
env GOOS=linux GOARCH=386 codeql$(EXE) test run -j0 ql/test/query-tests/Security/CWE-681 --search-path .. --consistency-queries ql/test/consistency --compilation-cache=$(cache) --dynamic-join-order-mode=$(rtjo)
|
|
cd extractor; $(BAZEL) test ...
|
|
bash extractor-smoke-test/test.sh || (echo "Extractor smoke test FAILED"; exit 1)
|
|
|
|
.PHONY: build/testdb/check-upgrade-path
|
|
build/testdb/check-upgrade-path : build/testdb/go.dbscheme ql/lib/go.dbscheme
|
|
codeql dataset upgrade build/testdb --search-path ql/lib
|
|
diff -u build/testdb/go.dbscheme ql/lib/go.dbscheme
|
|
|
|
.PHONY: build/testdb/go.dbscheme
|
|
build/testdb/go.dbscheme: ql/lib/upgrades/initial/go.dbscheme
|
|
rm -rf build/testdb
|
|
echo >build/empty.trap
|
|
codeql dataset import -S ql/lib/upgrades/initial/go.dbscheme build/testdb build/empty.trap
|