mirror of
https://github.com/github/codeql.git
synced 2026-04-29 18:55:14 +02:00
6333752014
This seems like something we have been missing for a while now, so I figured it might be useful to add. It is roughly based on the JavaScript equivalent, with one major difference: in the JavaScript libraries, `getAMethodCall` is reserved for syntactic method calls (`obj.m(...)`) whereas `getAMemberInvocation` is used for both this and the case where the bound method `obj.m` is stored in a temporary variable and then subsequently invoked in the same local scope. It seems to me that the more general predicate is more useful, and hence should have the simpler name. (And also we don't really work with a notion of "invocation" in the Python libraries, so we would need a better name for it anyway.) I think as long as the documentation makes the behaviour clear, it should be okay.