codeql

mirror of https://github.com/github/codeql.git synced 2026-04-25 08:45:14 +02:00

Files

Taus 5d6600e61f Python: Fix generator expression locations

Our logic for detecting the first and last item in a generator
expression was faulty, sometimes matching comments as well. Because
attributes (like `_location_start`) can only be written once, this
caused `tree-sitter-graph` to get unhappy.

To fix this, we now require the first item to be an `expression`, and
the last one to be either a `for_in_clause` or an `if_clause`.
Crucially, `comment` is neither of these, and this prevents the
unfortunate overlap.

2024-10-28 14:53:09 +00:00