mirror of
https://github.com/github/codeql.git
synced 2026-06-25 06:37:07 +02:00
5081d8171e
Flips the Python dataflow trunk from the legacy CFG (semmle/python/Flow.qll) and legacy ESSA SSA (semmle/python/essa/*) to the new shared CFG facade (semmle.python.controlflow.internal.Cfg) and the new SSA adapter (semmle.python.dataflow.new.internal.SsaImpl), both introduced additively in the preceding PRs in this stack. This is the trunk-flip equivalent of the original draft PR #21894 (kept around as documentation), rebased on top of the four preparatory PRs: P1: Remove AstNode.getAFlowNode() and rewrite callers (#21919). P2: Qualify Flow.qll's AST references with Py:: prefix (#21920). P3: Add new shared-CFG-backed control flow graph (#21921). P4: Add new shared-SSA-backed SSA adapter (#21923). The Python dataflow library (semmle/python/dataflow/new/) now imports the new CFG facade and SSA adapter. All CFG-typed predicates (ControlFlowNode, CallNode, BasicBlock, NameNode, AttrNode, ...) are qualified with the Cfg:: prefix; SSA references switch from EssaVariable/EssaDefinition to SsaImpl::Definition/SourceVariable. GuardNode is redesigned to use the new CFG's outcome-node model (isAfterTrue / isAfterFalse) instead of the legacy ConditionBlock + flipped indirection. Only BarrierGuard<...> is preserved as public API. Framework files (Bottle, FastApi, Django, Tornado, Pyramid, Stdlib, ...) are updated to take CFG nodes from the new facade. A handful of dataflow consistency tweaks for the new CFG: - Augmented-assignment targets are treated as both load and store. - 'from X import *' produces uncertain SSA writes for unknown names. - CFG nodes are canonicalised so dataflow does not see equivalent pre/post-order pairs as distinct nodes. Two AST tweaks for the new CFG: - AstNodeImpl: omit PEP 695 type-parameter names from FunctionDefExpr / ClassDefExpr children. - ImportResolution: drop the legacy essa import. Test churn (~175 files): reblessed library- and query-test .expected files reflect slightly different CFG granularity, different toString output, and a handful of true alert deltas in security queries. Verification: all 367 lib + src + consistency-queries compile clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
10 lines
1.3 KiB
Plaintext
10 lines
1.3 KiB
Plaintext
| resources_test.py:6:10:6:25 | open() | File may not be closed if $@ raises an exception. | resources_test.py:7:5:7:33 | Attribute() | this operation |
|
|
| resources_test.py:11:10:11:25 | open() | File is opened but is not closed. | file://:0:0:0:0 | (none) | this operation |
|
|
| resources_test.py:110:11:110:20 | open() | File is opened but is not closed. | file://:0:0:0:0 | (none) | this operation |
|
|
| resources_test.py:114:11:114:28 | opener_func2() | File may not be closed if $@ raises an exception. | resources_test.py:115:5:115:22 | Attribute() | this operation |
|
|
| resources_test.py:125:11:125:24 | opener_func2() | File is opened but is not closed. | file://:0:0:0:0 | (none) | this operation |
|
|
| resources_test.py:131:15:131:24 | open() | File may not be closed if $@ raises an exception. | resources_test.py:132:9:132:26 | Attribute() | this operation |
|
|
| resources_test.py:250:11:250:25 | open() | File is opened but is not closed. | file://:0:0:0:0 | (none) | this operation |
|
|
| resources_test.py:271:10:271:27 | Attribute() | File may not be closed if $@ raises an exception. | resources_test.py:273:5:273:19 | Attribute() | this operation |
|
|
| resources_test.py:287:11:287:20 | open() | File may not be closed if $@ raises an exception. | resources_test.py:289:5:289:31 | Attribute() | this operation |
|