mirror of
https://github.com/github/codeql.git
synced 2026-06-05 05:27:04 +02:00
4ed5722e3e
Flips the Python dataflow trunk from the legacy CFG (semmle/python/Flow.qll) and legacy ESSA SSA (semmle/python/essa/*) to the new shared CFG facade (semmle.python.controlflow.internal.Cfg) and the new SSA adapter (semmle.python.dataflow.new.internal.SsaImpl), both introduced additively in the preceding PRs in this stack. This is the trunk-flip equivalent of the original draft PR #21894 (kept around as documentation), rebased on top of the four preparatory PRs: P1: Remove AstNode.getAFlowNode() and rewrite callers (#21919). P2: Qualify Flow.qll's AST references with Py:: prefix (#21920). P3: Add new shared-CFG-backed control flow graph (#21921). P4: Add new shared-SSA-backed SSA adapter (#21923). The Python dataflow library (semmle/python/dataflow/new/) now imports the new CFG facade and SSA adapter. All CFG-typed predicates (ControlFlowNode, CallNode, BasicBlock, NameNode, AttrNode, ...) are qualified with the Cfg:: prefix; SSA references switch from EssaVariable/EssaDefinition to SsaImpl::Definition/SourceVariable. GuardNode is redesigned to use the new CFG's outcome-node model (isAfterTrue / isAfterFalse) instead of the legacy ConditionBlock + flipped indirection. Only BarrierGuard<...> is preserved as public API. Framework files (Bottle, FastApi, Django, Tornado, Pyramid, Stdlib, ...) are updated to take CFG nodes from the new facade. A handful of dataflow consistency tweaks for the new CFG: - Augmented-assignment targets are treated as both load and store. - 'from X import *' produces uncertain SSA writes for unknown names. - CFG nodes are canonicalised so dataflow does not see equivalent pre/post-order pairs as distinct nodes. Two AST tweaks for the new CFG: - AstNodeImpl: omit PEP 695 type-parameter names from FunctionDefExpr / ClassDefExpr children. - ImportResolution: drop the legacy essa import. Test churn (~175 files): reblessed library- and query-test .expected files reflect slightly different CFG granularity, different toString output, and a handful of true alert deltas in security queries. Verification: all 367 lib + src + consistency-queries compile clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
111 lines
12 KiB
Plaintext
111 lines
12 KiB
Plaintext
edges
|
|
| command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:5:26:5:32 | request | provenance | |
|
|
| command_injection.py:5:26:5:32 | request | command_injection.py:11:13:11:19 | request | provenance | |
|
|
| command_injection.py:5:26:5:32 | request | command_injection.py:18:13:18:19 | request | provenance | |
|
|
| command_injection.py:5:26:5:32 | request | command_injection.py:25:11:25:17 | request | provenance | |
|
|
| command_injection.py:5:26:5:32 | request | command_injection.py:31:13:31:19 | request | provenance | |
|
|
| command_injection.py:5:26:5:32 | request | command_injection.py:38:15:38:21 | request | provenance | |
|
|
| command_injection.py:5:26:5:32 | request | command_injection.py:54:15:54:21 | request | provenance | |
|
|
| command_injection.py:5:26:5:32 | request | command_injection.py:71:12:71:18 | request | provenance | |
|
|
| command_injection.py:5:26:5:32 | request | command_injection.py:78:12:78:18 | request | provenance | |
|
|
| command_injection.py:11:5:11:9 | files | command_injection.py:13:15:13:27 | After BinaryExpr | provenance | |
|
|
| command_injection.py:11:13:11:19 | request | command_injection.py:11:13:11:24 | After Attribute | provenance | AdditionalTaintStep |
|
|
| command_injection.py:11:13:11:24 | After Attribute | command_injection.py:11:13:11:41 | After Attribute() | provenance | dict.get |
|
|
| command_injection.py:11:13:11:41 | After Attribute() | command_injection.py:11:5:11:9 | files | provenance | |
|
|
| command_injection.py:18:5:18:9 | files | command_injection.py:20:22:20:34 | After BinaryExpr | provenance | |
|
|
| command_injection.py:18:13:18:19 | request | command_injection.py:18:13:18:24 | After Attribute | provenance | AdditionalTaintStep |
|
|
| command_injection.py:18:13:18:24 | After Attribute | command_injection.py:18:13:18:41 | After Attribute() | provenance | dict.get |
|
|
| command_injection.py:18:13:18:41 | After Attribute() | command_injection.py:18:5:18:9 | files | provenance | |
|
|
| command_injection.py:25:5:25:7 | cmd | command_injection.py:26:23:26:25 | cmd | provenance | |
|
|
| command_injection.py:25:11:25:17 | request | command_injection.py:25:11:25:22 | After Attribute | provenance | AdditionalTaintStep |
|
|
| command_injection.py:25:11:25:22 | After Attribute | command_injection.py:25:11:25:37 | After Attribute() | provenance | dict.get |
|
|
| command_injection.py:25:11:25:37 | After Attribute() | command_injection.py:25:5:25:7 | cmd | provenance | |
|
|
| command_injection.py:31:5:31:9 | files | command_injection.py:33:14:33:26 | After BinaryExpr | provenance | |
|
|
| command_injection.py:31:13:31:19 | request | command_injection.py:31:13:31:24 | After Attribute | provenance | AdditionalTaintStep |
|
|
| command_injection.py:31:13:31:24 | After Attribute | command_injection.py:31:13:31:41 | After Attribute() | provenance | dict.get |
|
|
| command_injection.py:31:13:31:41 | After Attribute() | command_injection.py:31:5:31:9 | files | provenance | |
|
|
| command_injection.py:38:5:38:11 | command | command_injection.py:41:15:41:21 | command | provenance | |
|
|
| command_injection.py:38:5:38:11 | command | command_injection.py:42:15:42:21 | command | provenance | |
|
|
| command_injection.py:38:15:38:21 | request | command_injection.py:38:15:38:26 | After Attribute | provenance | AdditionalTaintStep |
|
|
| command_injection.py:38:15:38:26 | After Attribute | command_injection.py:38:15:38:45 | After Attribute() | provenance | dict.get |
|
|
| command_injection.py:38:15:38:45 | After Attribute() | command_injection.py:38:5:38:11 | command | provenance | |
|
|
| command_injection.py:54:5:54:11 | command | command_injection.py:55:15:55:21 | command | provenance | |
|
|
| command_injection.py:54:5:54:11 | command | command_injection.py:56:14:56:20 | command | provenance | |
|
|
| command_injection.py:54:5:54:11 | command | command_injection.py:57:21:57:27 | command | provenance | |
|
|
| command_injection.py:54:5:54:11 | command | command_injection.py:58:27:58:33 | command | provenance | |
|
|
| command_injection.py:54:5:54:11 | command | command_injection.py:59:20:59:26 | command | provenance | |
|
|
| command_injection.py:54:15:54:21 | request | command_injection.py:54:15:54:26 | After Attribute | provenance | AdditionalTaintStep |
|
|
| command_injection.py:54:15:54:26 | After Attribute | command_injection.py:54:15:54:45 | After Attribute() | provenance | dict.get |
|
|
| command_injection.py:54:15:54:45 | After Attribute() | command_injection.py:54:5:54:11 | command | provenance | |
|
|
| command_injection.py:71:5:71:8 | path | command_injection.py:73:19:73:30 | After BinaryExpr | provenance | |
|
|
| command_injection.py:71:12:71:18 | request | command_injection.py:71:12:71:23 | After Attribute | provenance | AdditionalTaintStep |
|
|
| command_injection.py:71:12:71:23 | After Attribute | command_injection.py:71:12:71:39 | After Attribute() | provenance | dict.get |
|
|
| command_injection.py:71:12:71:39 | After Attribute() | command_injection.py:71:5:71:8 | path | provenance | |
|
|
| command_injection.py:78:5:78:8 | path | command_injection.py:80:19:80:30 | After BinaryExpr | provenance | |
|
|
| command_injection.py:78:12:78:18 | request | command_injection.py:78:12:78:23 | After Attribute | provenance | AdditionalTaintStep |
|
|
| command_injection.py:78:12:78:23 | After Attribute | command_injection.py:78:12:78:39 | After Attribute() | provenance | dict.get |
|
|
| command_injection.py:78:12:78:39 | After Attribute() | command_injection.py:78:5:78:8 | path | provenance | |
|
|
nodes
|
|
| command_injection.py:5:26:5:32 | After ImportMember | semmle.label | After ImportMember |
|
|
| command_injection.py:5:26:5:32 | request | semmle.label | request |
|
|
| command_injection.py:11:5:11:9 | files | semmle.label | files |
|
|
| command_injection.py:11:13:11:19 | request | semmle.label | request |
|
|
| command_injection.py:11:13:11:24 | After Attribute | semmle.label | After Attribute |
|
|
| command_injection.py:11:13:11:41 | After Attribute() | semmle.label | After Attribute() |
|
|
| command_injection.py:13:15:13:27 | After BinaryExpr | semmle.label | After BinaryExpr |
|
|
| command_injection.py:18:5:18:9 | files | semmle.label | files |
|
|
| command_injection.py:18:13:18:19 | request | semmle.label | request |
|
|
| command_injection.py:18:13:18:24 | After Attribute | semmle.label | After Attribute |
|
|
| command_injection.py:18:13:18:41 | After Attribute() | semmle.label | After Attribute() |
|
|
| command_injection.py:20:22:20:34 | After BinaryExpr | semmle.label | After BinaryExpr |
|
|
| command_injection.py:25:5:25:7 | cmd | semmle.label | cmd |
|
|
| command_injection.py:25:11:25:17 | request | semmle.label | request |
|
|
| command_injection.py:25:11:25:22 | After Attribute | semmle.label | After Attribute |
|
|
| command_injection.py:25:11:25:37 | After Attribute() | semmle.label | After Attribute() |
|
|
| command_injection.py:26:23:26:25 | cmd | semmle.label | cmd |
|
|
| command_injection.py:31:5:31:9 | files | semmle.label | files |
|
|
| command_injection.py:31:13:31:19 | request | semmle.label | request |
|
|
| command_injection.py:31:13:31:24 | After Attribute | semmle.label | After Attribute |
|
|
| command_injection.py:31:13:31:41 | After Attribute() | semmle.label | After Attribute() |
|
|
| command_injection.py:33:14:33:26 | After BinaryExpr | semmle.label | After BinaryExpr |
|
|
| command_injection.py:38:5:38:11 | command | semmle.label | command |
|
|
| command_injection.py:38:15:38:21 | request | semmle.label | request |
|
|
| command_injection.py:38:15:38:26 | After Attribute | semmle.label | After Attribute |
|
|
| command_injection.py:38:15:38:45 | After Attribute() | semmle.label | After Attribute() |
|
|
| command_injection.py:41:15:41:21 | command | semmle.label | command |
|
|
| command_injection.py:42:15:42:21 | command | semmle.label | command |
|
|
| command_injection.py:54:5:54:11 | command | semmle.label | command |
|
|
| command_injection.py:54:15:54:21 | request | semmle.label | request |
|
|
| command_injection.py:54:15:54:26 | After Attribute | semmle.label | After Attribute |
|
|
| command_injection.py:54:15:54:45 | After Attribute() | semmle.label | After Attribute() |
|
|
| command_injection.py:55:15:55:21 | command | semmle.label | command |
|
|
| command_injection.py:56:14:56:20 | command | semmle.label | command |
|
|
| command_injection.py:57:21:57:27 | command | semmle.label | command |
|
|
| command_injection.py:58:27:58:33 | command | semmle.label | command |
|
|
| command_injection.py:59:20:59:26 | command | semmle.label | command |
|
|
| command_injection.py:71:5:71:8 | path | semmle.label | path |
|
|
| command_injection.py:71:12:71:18 | request | semmle.label | request |
|
|
| command_injection.py:71:12:71:23 | After Attribute | semmle.label | After Attribute |
|
|
| command_injection.py:71:12:71:39 | After Attribute() | semmle.label | After Attribute() |
|
|
| command_injection.py:73:19:73:30 | After BinaryExpr | semmle.label | After BinaryExpr |
|
|
| command_injection.py:78:5:78:8 | path | semmle.label | path |
|
|
| command_injection.py:78:12:78:18 | request | semmle.label | request |
|
|
| command_injection.py:78:12:78:23 | After Attribute | semmle.label | After Attribute |
|
|
| command_injection.py:78:12:78:39 | After Attribute() | semmle.label | After Attribute() |
|
|
| command_injection.py:80:19:80:30 | After BinaryExpr | semmle.label | After BinaryExpr |
|
|
subpaths
|
|
#select
|
|
| command_injection.py:13:15:13:27 | After BinaryExpr | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:13:15:13:27 | After BinaryExpr | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:20:22:20:34 | After BinaryExpr | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:20:22:20:34 | After BinaryExpr | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:26:23:26:25 | cmd | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:26:23:26:25 | cmd | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:33:14:33:26 | After BinaryExpr | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:33:14:33:26 | After BinaryExpr | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:41:15:41:21 | command | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:41:15:41:21 | command | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:42:15:42:21 | command | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:42:15:42:21 | command | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:55:15:55:21 | command | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:55:15:55:21 | command | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:56:14:56:20 | command | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:56:14:56:20 | command | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:57:21:57:27 | command | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:57:21:57:27 | command | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:58:27:58:33 | command | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:58:27:58:33 | command | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:59:20:59:26 | command | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:59:20:59:26 | command | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:73:19:73:30 | After BinaryExpr | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:73:19:73:30 | After BinaryExpr | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|
|
| command_injection.py:80:19:80:30 | After BinaryExpr | command_injection.py:5:26:5:32 | After ImportMember | command_injection.py:80:19:80:30 | After BinaryExpr | This command line depends on a $@. | command_injection.py:5:26:5:32 | After ImportMember | user-provided value |
|