mirror of
https://github.com/github/codeql.git
synced 2026-06-04 21:19:50 +02:00
4ed5722e3e
Flips the Python dataflow trunk from the legacy CFG (semmle/python/Flow.qll) and legacy ESSA SSA (semmle/python/essa/*) to the new shared CFG facade (semmle.python.controlflow.internal.Cfg) and the new SSA adapter (semmle.python.dataflow.new.internal.SsaImpl), both introduced additively in the preceding PRs in this stack. This is the trunk-flip equivalent of the original draft PR #21894 (kept around as documentation), rebased on top of the four preparatory PRs: P1: Remove AstNode.getAFlowNode() and rewrite callers (#21919). P2: Qualify Flow.qll's AST references with Py:: prefix (#21920). P3: Add new shared-CFG-backed control flow graph (#21921). P4: Add new shared-SSA-backed SSA adapter (#21923). The Python dataflow library (semmle/python/dataflow/new/) now imports the new CFG facade and SSA adapter. All CFG-typed predicates (ControlFlowNode, CallNode, BasicBlock, NameNode, AttrNode, ...) are qualified with the Cfg:: prefix; SSA references switch from EssaVariable/EssaDefinition to SsaImpl::Definition/SourceVariable. GuardNode is redesigned to use the new CFG's outcome-node model (isAfterTrue / isAfterFalse) instead of the legacy ConditionBlock + flipped indirection. Only BarrierGuard<...> is preserved as public API. Framework files (Bottle, FastApi, Django, Tornado, Pyramid, Stdlib, ...) are updated to take CFG nodes from the new facade. A handful of dataflow consistency tweaks for the new CFG: - Augmented-assignment targets are treated as both load and store. - 'from X import *' produces uncertain SSA writes for unknown names. - CFG nodes are canonicalised so dataflow does not see equivalent pre/post-order pairs as distinct nodes. Two AST tweaks for the new CFG: - AstNodeImpl: omit PEP 695 type-parameter names from FunctionDefExpr / ClassDefExpr children. - ImportResolution: drop the legacy essa import. Test churn (~175 files): reblessed library- and query-test .expected files reflect slightly different CFG granularity, different toString output, and a handful of true alert deltas in security queries. Verification: all 367 lib + src + consistency-queries compile clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
133 lines
9.6 KiB
Plaintext
133 lines
9.6 KiB
Plaintext
edges
|
|
| test.py:2:12:2:12 | l | test.py:3:5:3:5 | l | provenance | |
|
|
| test.py:7:11:7:11 | l | test.py:8:5:8:5 | l | provenance | |
|
|
| test.py:12:14:12:14 | l | test.py:13:9:13:9 | l | provenance | |
|
|
| test.py:17:15:17:15 | l | test.py:18:5:18:5 | l | provenance | |
|
|
| test.py:22:15:22:15 | l | test.py:23:5:23:5 | l | provenance | |
|
|
| test.py:27:12:27:12 | l | test.py:28:5:28:5 | l | provenance | |
|
|
| test.py:38:13:38:13 | l | test.py:39:5:39:5 | l | provenance | |
|
|
| test.py:43:14:43:14 | l | test.py:44:13:44:13 | l | provenance | |
|
|
| test.py:44:13:44:13 | l | test.py:38:13:38:13 | l | provenance | |
|
|
| test.py:48:14:48:14 | l | test.py:49:5:49:5 | l | provenance | |
|
|
| test.py:53:10:53:10 | d | test.py:54:5:54:5 | d | provenance | |
|
|
| test.py:58:19:58:19 | d | test.py:59:5:59:5 | d | provenance | |
|
|
| test.py:63:28:63:28 | d | test.py:64:5:64:5 | d | provenance | |
|
|
| test.py:67:14:67:14 | d | test.py:68:5:68:5 | d | provenance | |
|
|
| test.py:72:19:72:19 | d | test.py:73:14:73:14 | d | provenance | |
|
|
| test.py:73:14:73:14 | d | test.py:67:14:67:14 | d | provenance | |
|
|
| test.py:77:17:77:17 | d | test.py:78:5:78:5 | d | provenance | |
|
|
| test.py:82:26:82:26 | d | test.py:83:5:83:5 | d | provenance | |
|
|
| test.py:87:35:87:35 | d | test.py:88:5:88:5 | d | provenance | |
|
|
| test.py:91:21:91:21 | d | test.py:92:5:92:5 | d | provenance | |
|
|
| test.py:96:26:96:26 | d | test.py:97:21:97:21 | d | provenance | |
|
|
| test.py:97:21:97:21 | d | test.py:91:21:91:21 | d | provenance | |
|
|
| test.py:108:14:108:14 | d | test.py:109:9:109:9 | d | provenance | |
|
|
| test.py:113:20:113:20 | d | test.py:115:5:115:5 | d | provenance | |
|
|
| test.py:119:29:119:29 | d | test.py:121:5:121:5 | d | provenance | |
|
|
| test.py:131:23:131:23 | l | test.py:135:9:135:9 | l | provenance | |
|
|
| test.py:145:23:145:23 | l | test.py:147:9:147:9 | l | provenance | |
|
|
| test.py:153:25:153:25 | x | test.py:154:5:154:5 | x | provenance | |
|
|
| test.py:156:21:156:21 | x | test.py:157:5:157:5 | x | provenance | |
|
|
| test.py:159:27:159:27 | y | test.py:160:25:160:25 | y | provenance | |
|
|
| test.py:159:27:159:27 | y | test.py:161:21:161:21 | y | provenance | |
|
|
| test.py:160:25:160:25 | y | test.py:153:25:153:25 | x | provenance | |
|
|
| test.py:161:21:161:21 | y | test.py:156:21:156:21 | x | provenance | |
|
|
| test.py:181:28:181:28 | x | test.py:185:9:185:9 | x | provenance | |
|
|
| test.py:181:28:181:28 | x | test.py:187:9:187:9 | x | provenance | |
|
|
| test.py:194:18:194:18 | x | test.py:195:28:195:28 | x | provenance | |
|
|
| test.py:195:28:195:28 | x | test.py:181:28:181:28 | x | provenance | |
|
|
| test.py:197:18:197:18 | x | test.py:198:28:198:28 | x | provenance | |
|
|
| test.py:198:28:198:28 | x | test.py:181:28:181:28 | x | provenance | |
|
|
nodes
|
|
| test.py:2:12:2:12 | l | semmle.label | l |
|
|
| test.py:3:5:3:5 | l | semmle.label | l |
|
|
| test.py:7:11:7:11 | l | semmle.label | l |
|
|
| test.py:8:5:8:5 | l | semmle.label | l |
|
|
| test.py:12:14:12:14 | l | semmle.label | l |
|
|
| test.py:13:9:13:9 | l | semmle.label | l |
|
|
| test.py:17:15:17:15 | l | semmle.label | l |
|
|
| test.py:18:5:18:5 | l | semmle.label | l |
|
|
| test.py:22:15:22:15 | l | semmle.label | l |
|
|
| test.py:23:5:23:5 | l | semmle.label | l |
|
|
| test.py:27:12:27:12 | l | semmle.label | l |
|
|
| test.py:28:5:28:5 | l | semmle.label | l |
|
|
| test.py:38:13:38:13 | l | semmle.label | l |
|
|
| test.py:39:5:39:5 | l | semmle.label | l |
|
|
| test.py:43:14:43:14 | l | semmle.label | l |
|
|
| test.py:44:13:44:13 | l | semmle.label | l |
|
|
| test.py:48:14:48:14 | l | semmle.label | l |
|
|
| test.py:49:5:49:5 | l | semmle.label | l |
|
|
| test.py:53:10:53:10 | d | semmle.label | d |
|
|
| test.py:54:5:54:5 | d | semmle.label | d |
|
|
| test.py:58:19:58:19 | d | semmle.label | d |
|
|
| test.py:59:5:59:5 | d | semmle.label | d |
|
|
| test.py:63:28:63:28 | d | semmle.label | d |
|
|
| test.py:64:5:64:5 | d | semmle.label | d |
|
|
| test.py:67:14:67:14 | d | semmle.label | d |
|
|
| test.py:68:5:68:5 | d | semmle.label | d |
|
|
| test.py:72:19:72:19 | d | semmle.label | d |
|
|
| test.py:73:14:73:14 | d | semmle.label | d |
|
|
| test.py:77:17:77:17 | d | semmle.label | d |
|
|
| test.py:78:5:78:5 | d | semmle.label | d |
|
|
| test.py:82:26:82:26 | d | semmle.label | d |
|
|
| test.py:83:5:83:5 | d | semmle.label | d |
|
|
| test.py:87:35:87:35 | d | semmle.label | d |
|
|
| test.py:88:5:88:5 | d | semmle.label | d |
|
|
| test.py:91:21:91:21 | d | semmle.label | d |
|
|
| test.py:92:5:92:5 | d | semmle.label | d |
|
|
| test.py:96:26:96:26 | d | semmle.label | d |
|
|
| test.py:97:21:97:21 | d | semmle.label | d |
|
|
| test.py:108:14:108:14 | d | semmle.label | d |
|
|
| test.py:109:9:109:9 | d | semmle.label | d |
|
|
| test.py:113:20:113:20 | d | semmle.label | d |
|
|
| test.py:115:5:115:5 | d | semmle.label | d |
|
|
| test.py:119:29:119:29 | d | semmle.label | d |
|
|
| test.py:121:5:121:5 | d | semmle.label | d |
|
|
| test.py:131:23:131:23 | l | semmle.label | l |
|
|
| test.py:135:9:135:9 | l | semmle.label | l |
|
|
| test.py:145:23:145:23 | l | semmle.label | l |
|
|
| test.py:147:9:147:9 | l | semmle.label | l |
|
|
| test.py:153:25:153:25 | x | semmle.label | x |
|
|
| test.py:154:5:154:5 | x | semmle.label | x |
|
|
| test.py:156:21:156:21 | x | semmle.label | x |
|
|
| test.py:157:5:157:5 | x | semmle.label | x |
|
|
| test.py:159:27:159:27 | y | semmle.label | y |
|
|
| test.py:160:25:160:25 | y | semmle.label | y |
|
|
| test.py:161:21:161:21 | y | semmle.label | y |
|
|
| test.py:181:28:181:28 | x | semmle.label | x |
|
|
| test.py:185:9:185:9 | x | semmle.label | x |
|
|
| test.py:187:9:187:9 | x | semmle.label | x |
|
|
| test.py:194:18:194:18 | x | semmle.label | x |
|
|
| test.py:195:28:195:28 | x | semmle.label | x |
|
|
| test.py:197:18:197:18 | x | semmle.label | x |
|
|
| test.py:198:28:198:28 | x | semmle.label | x |
|
|
subpaths
|
|
#select
|
|
| test.py:3:5:3:5 | l | test.py:2:12:2:12 | l | test.py:3:5:3:5 | l | This expression mutates a $@. | test.py:2:12:2:12 | l | default value |
|
|
| test.py:8:5:8:5 | l | test.py:7:11:7:11 | l | test.py:8:5:8:5 | l | This expression mutates a $@. | test.py:7:11:7:11 | l | default value |
|
|
| test.py:13:9:13:9 | l | test.py:12:14:12:14 | l | test.py:13:9:13:9 | l | This expression mutates a $@. | test.py:12:14:12:14 | l | default value |
|
|
| test.py:18:5:18:5 | l | test.py:17:15:17:15 | l | test.py:18:5:18:5 | l | This expression mutates a $@. | test.py:17:15:17:15 | l | default value |
|
|
| test.py:23:5:23:5 | l | test.py:22:15:22:15 | l | test.py:23:5:23:5 | l | This expression mutates a $@. | test.py:22:15:22:15 | l | default value |
|
|
| test.py:28:5:28:5 | l | test.py:27:12:27:12 | l | test.py:28:5:28:5 | l | This expression mutates a $@. | test.py:27:12:27:12 | l | default value |
|
|
| test.py:39:5:39:5 | l | test.py:43:14:43:14 | l | test.py:39:5:39:5 | l | This expression mutates a $@. | test.py:43:14:43:14 | l | default value |
|
|
| test.py:49:5:49:5 | l | test.py:48:14:48:14 | l | test.py:49:5:49:5 | l | This expression mutates a $@. | test.py:48:14:48:14 | l | default value |
|
|
| test.py:54:5:54:5 | d | test.py:53:10:53:10 | d | test.py:54:5:54:5 | d | This expression mutates a $@. | test.py:53:10:53:10 | d | default value |
|
|
| test.py:59:5:59:5 | d | test.py:58:19:58:19 | d | test.py:59:5:59:5 | d | This expression mutates a $@. | test.py:58:19:58:19 | d | default value |
|
|
| test.py:64:5:64:5 | d | test.py:63:28:63:28 | d | test.py:64:5:64:5 | d | This expression mutates a $@. | test.py:63:28:63:28 | d | default value |
|
|
| test.py:68:5:68:5 | d | test.py:72:19:72:19 | d | test.py:68:5:68:5 | d | This expression mutates a $@. | test.py:72:19:72:19 | d | default value |
|
|
| test.py:78:5:78:5 | d | test.py:77:17:77:17 | d | test.py:78:5:78:5 | d | This expression mutates a $@. | test.py:77:17:77:17 | d | default value |
|
|
| test.py:83:5:83:5 | d | test.py:82:26:82:26 | d | test.py:83:5:83:5 | d | This expression mutates a $@. | test.py:82:26:82:26 | d | default value |
|
|
| test.py:88:5:88:5 | d | test.py:87:35:87:35 | d | test.py:88:5:88:5 | d | This expression mutates a $@. | test.py:87:35:87:35 | d | default value |
|
|
| test.py:92:5:92:5 | d | test.py:96:26:96:26 | d | test.py:92:5:92:5 | d | This expression mutates a $@. | test.py:96:26:96:26 | d | default value |
|
|
| test.py:109:9:109:9 | d | test.py:108:14:108:14 | d | test.py:109:9:109:9 | d | This expression mutates a $@. | test.py:108:14:108:14 | d | default value |
|
|
| test.py:115:5:115:5 | d | test.py:113:20:113:20 | d | test.py:115:5:115:5 | d | This expression mutates a $@. | test.py:113:20:113:20 | d | default value |
|
|
| test.py:121:5:121:5 | d | test.py:119:29:119:29 | d | test.py:121:5:121:5 | d | This expression mutates a $@. | test.py:119:29:119:29 | d | default value |
|
|
| test.py:135:9:135:9 | l | test.py:131:23:131:23 | l | test.py:135:9:135:9 | l | This expression mutates a $@. | test.py:131:23:131:23 | l | default value |
|
|
| test.py:147:9:147:9 | l | test.py:145:23:145:23 | l | test.py:147:9:147:9 | l | This expression mutates a $@. | test.py:145:23:145:23 | l | default value |
|
|
| test.py:154:5:154:5 | x | test.py:159:27:159:27 | y | test.py:154:5:154:5 | x | This expression mutates a $@. | test.py:159:27:159:27 | y | default value |
|
|
| test.py:157:5:157:5 | x | test.py:159:27:159:27 | y | test.py:157:5:157:5 | x | This expression mutates a $@. | test.py:159:27:159:27 | y | default value |
|
|
| test.py:185:9:185:9 | x | test.py:194:18:194:18 | x | test.py:185:9:185:9 | x | This expression mutates a $@. | test.py:194:18:194:18 | x | default value |
|
|
| test.py:185:9:185:9 | x | test.py:197:18:197:18 | x | test.py:185:9:185:9 | x | This expression mutates a $@. | test.py:197:18:197:18 | x | default value |
|
|
| test.py:187:9:187:9 | x | test.py:194:18:194:18 | x | test.py:187:9:187:9 | x | This expression mutates a $@. | test.py:194:18:194:18 | x | default value |
|
|
| test.py:187:9:187:9 | x | test.py:197:18:197:18 | x | test.py:187:9:187:9 | x | This expression mutates a $@. | test.py:197:18:197:18 | x | default value |
|