mirror of
https://github.com/github/codeql.git
synced 2026-06-03 12:50:16 +02:00
4ed5722e3e
Flips the Python dataflow trunk from the legacy CFG (semmle/python/Flow.qll) and legacy ESSA SSA (semmle/python/essa/*) to the new shared CFG facade (semmle.python.controlflow.internal.Cfg) and the new SSA adapter (semmle.python.dataflow.new.internal.SsaImpl), both introduced additively in the preceding PRs in this stack. This is the trunk-flip equivalent of the original draft PR #21894 (kept around as documentation), rebased on top of the four preparatory PRs: P1: Remove AstNode.getAFlowNode() and rewrite callers (#21919). P2: Qualify Flow.qll's AST references with Py:: prefix (#21920). P3: Add new shared-CFG-backed control flow graph (#21921). P4: Add new shared-SSA-backed SSA adapter (#21923). The Python dataflow library (semmle/python/dataflow/new/) now imports the new CFG facade and SSA adapter. All CFG-typed predicates (ControlFlowNode, CallNode, BasicBlock, NameNode, AttrNode, ...) are qualified with the Cfg:: prefix; SSA references switch from EssaVariable/EssaDefinition to SsaImpl::Definition/SourceVariable. GuardNode is redesigned to use the new CFG's outcome-node model (isAfterTrue / isAfterFalse) instead of the legacy ConditionBlock + flipped indirection. Only BarrierGuard<...> is preserved as public API. Framework files (Bottle, FastApi, Django, Tornado, Pyramid, Stdlib, ...) are updated to take CFG nodes from the new facade. A handful of dataflow consistency tweaks for the new CFG: - Augmented-assignment targets are treated as both load and store. - 'from X import *' produces uncertain SSA writes for unknown names. - CFG nodes are canonicalised so dataflow does not see equivalent pre/post-order pairs as distinct nodes. Two AST tweaks for the new CFG: - AstNodeImpl: omit PEP 695 type-parameter names from FunctionDefExpr / ClassDefExpr children. - ImportResolution: drop the legacy essa import. Test churn (~175 files): reblessed library- and query-test .expected files reflect slightly different CFG granularity, different toString output, and a handful of true alert deltas in security queries. Verification: all 367 lib + src + consistency-queries compile clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
47 lines
3.5 KiB
Plaintext
47 lines
3.5 KiB
Plaintext
edges
|
|
| test.py:21:11:21:18 | After source() | test.py:22:10:22:24 | After Attribute() | provenance | AdditionalTaintStep |
|
|
| test.py:29:11:29:18 | After source() | test.py:32:5:32:7 | val | provenance | AdditionalTaintStep |
|
|
| test.py:32:5:32:7 | val | test.py:33:10:33:12 | val | provenance | |
|
|
| test.py:40:5:40:7 | val | test.py:41:10:41:12 | val | provenance | |
|
|
| test.py:40:11:40:25 | After Attribute() | test.py:40:5:40:7 | val | provenance | |
|
|
| test.py:45:11:45:18 | After source() | test.py:40:11:40:25 | After Attribute() | provenance | AdditionalTaintStep |
|
|
| test.py:53:5:53:7 | val | test.py:54:10:54:12 | val | provenance | |
|
|
| test.py:53:11:53:25 | After Attribute() | test.py:53:5:53:7 | val | provenance | |
|
|
| test.py:70:11:70:18 | After source() | test.py:53:11:53:25 | After Attribute() | provenance | AdditionalTaintStep |
|
|
| test.py:78:5:78:7 | val | test.py:79:10:79:12 | val | provenance | |
|
|
| test.py:78:11:78:14 | After bm() | test.py:78:5:78:7 | val | provenance | |
|
|
| test.py:83:11:83:18 | After source() | test.py:78:11:78:14 | After bm() | provenance | AdditionalTaintStep |
|
|
| test.py:90:5:90:7 | val | test.py:91:10:91:12 | val | provenance | |
|
|
| test.py:90:11:90:14 | After bm() | test.py:90:5:90:7 | val | provenance | |
|
|
| test.py:107:11:107:18 | After source() | test.py:90:11:90:14 | After bm() | provenance | AdditionalTaintStep |
|
|
nodes
|
|
| test.py:21:11:21:18 | After source() | semmle.label | After source() |
|
|
| test.py:22:10:22:24 | After Attribute() | semmle.label | After Attribute() |
|
|
| test.py:29:11:29:18 | After source() | semmle.label | After source() |
|
|
| test.py:32:5:32:7 | val | semmle.label | val |
|
|
| test.py:33:10:33:12 | val | semmle.label | val |
|
|
| test.py:40:5:40:7 | val | semmle.label | val |
|
|
| test.py:40:11:40:25 | After Attribute() | semmle.label | After Attribute() |
|
|
| test.py:41:10:41:12 | val | semmle.label | val |
|
|
| test.py:45:11:45:18 | After source() | semmle.label | After source() |
|
|
| test.py:53:5:53:7 | val | semmle.label | val |
|
|
| test.py:53:11:53:25 | After Attribute() | semmle.label | After Attribute() |
|
|
| test.py:54:10:54:12 | val | semmle.label | val |
|
|
| test.py:70:11:70:18 | After source() | semmle.label | After source() |
|
|
| test.py:78:5:78:7 | val | semmle.label | val |
|
|
| test.py:78:11:78:14 | After bm() | semmle.label | After bm() |
|
|
| test.py:79:10:79:12 | val | semmle.label | val |
|
|
| test.py:83:11:83:18 | After source() | semmle.label | After source() |
|
|
| test.py:90:5:90:7 | val | semmle.label | val |
|
|
| test.py:90:11:90:14 | After bm() | semmle.label | After bm() |
|
|
| test.py:91:10:91:12 | val | semmle.label | val |
|
|
| test.py:107:11:107:18 | After source() | semmle.label | After source() |
|
|
subpaths
|
|
#select
|
|
| test.py:22:10:22:24 | After Attribute() | test.py:21:11:21:18 | After source() | test.py:22:10:22:24 | After Attribute() | test flow (naive): test_simple |
|
|
| test.py:33:10:33:12 | val | test.py:29:11:29:18 | After source() | test.py:33:10:33:12 | val | test flow (naive): test_alias |
|
|
| test.py:41:10:41:12 | val | test.py:45:11:45:18 | After source() | test.py:41:10:41:12 | val | test flow (naive): test_across_functions |
|
|
| test.py:54:10:54:12 | val | test.py:70:11:70:18 | After source() | test.py:54:10:54:12 | val | test flow (naive): test_deeply_nested |
|
|
| test.py:79:10:79:12 | val | test.py:83:11:83:18 | After source() | test.py:79:10:79:12 | val | test flow (naive): test_pass_bound_method |
|
|
| test.py:91:10:91:12 | val | test.py:107:11:107:18 | After source() | test.py:91:10:91:12 | val | test flow (naive): test_deeply_nested_bound_method |
|