mirror of
https://github.com/github/codeql.git
synced 2025-12-16 16:53:25 +01:00
- favour unary predicates over binary ones (the natural "conflicting access" is binary) - switch to a dual solution to trade recursion through forall for simple existentials. Co-authored-by: Anders Schack-Mulligen <aschackmull@github.com>
41 lines
697 B
Java
41 lines
697 B
Java
package examples;
|
|
|
|
import java.util.concurrent.locks.Lock;
|
|
import java.util.concurrent.locks.ReentrantLock;
|
|
|
|
@ThreadSafe
|
|
class FaultyTurnstileExample {
|
|
private Lock lock = new ReentrantLock();
|
|
private int count = 0;
|
|
|
|
public void inc() {
|
|
lock.lock();
|
|
count++; // $ MISSING: Alert
|
|
lock.unlock();
|
|
}
|
|
|
|
public void dec() {
|
|
count--; // $ Alert
|
|
}
|
|
}
|
|
|
|
@ThreadSafe
|
|
class FaultyTurnstileExample2 {
|
|
private Lock lock1 = new ReentrantLock();
|
|
private Lock lock2 = new ReentrantLock();
|
|
private int count = 0; // $ Alert
|
|
|
|
public void inc() {
|
|
lock1.lock();
|
|
count++;
|
|
lock1.unlock();
|
|
}
|
|
|
|
public void dec() {
|
|
lock2.lock();
|
|
count--;
|
|
lock2.unlock();
|
|
}
|
|
}
|
|
|