mirror of
https://github.com/github/codeql.git
synced 2026-06-24 14:17:05 +02:00
39e6bfc894
Preparatory refactor for the shared-CFG dataflow migration. Adds the adapter that mediates between the Python AST and the shared codeql.controlflow.ControlFlowGraph signature, plus the test suites that validate the new CFG directly against this adapter. The public facade is added in the following commit. Library additions: - semmle.python.controlflow.internal.AstNodeImpl — wraps Python's Stmt/Expr/Scope/Pattern and adds two synthetic kinds of node (BlockStmt for body slots, intermediate nodes for multi-operand boolean expressions) to satisfy the shared CFG signature. - lib/printCfgNew.ql — debug/visualisation query for the new CFG. - consistency-queries/CfgConsistency.ql — consistency query running the shared CFG's standard checks against Python. Test additions (all driven directly off AstNodeImpl): - ControlFlow/bindings/* — annotation-driven SSA-binding tests (annassign, compound, comprehension, decorated, except_handler, imports, match_pattern, parameters, simple, type_params, walrus_starred, with_stmt, dead_under_no_raise). - ControlFlow/evaluation-order/NewCfg*.ql — mirrors of the existing OldCfg evaluation-order self-validation suite, run against the new CFG via NewCfgImpl.qll. - Minor extensions to existing test_if.py / test_boolean.py + cosmetic .expected churn on a handful of OldCfg tests. No dataflow, SSA, or production query is migrated yet. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
27 lines
796 B
Plaintext
27 lines
796 B
Plaintext
/**
|
|
* New-CFG version of BasicBlockAnnotationGap.
|
|
*
|
|
* Original:
|
|
* Checks that within a basic block, if a node is annotated then its
|
|
* successor is also annotated (or excluded). A gap in annotations
|
|
* within a basic block indicates a missing annotation, since there
|
|
* are no branches to justify the gap.
|
|
*
|
|
* Nodes with exceptional successors are excluded, as the exception
|
|
* edge leaves the basic block and the normal successor may be dead.
|
|
*/
|
|
|
|
import python
|
|
import TimerUtils
|
|
import NewCfgImpl
|
|
|
|
private module Utils = EvalOrderCfgUtils<NewCfg>;
|
|
|
|
private import Utils
|
|
private import Utils::CfgTests
|
|
|
|
from TimerCfgNode a, CfgNode succ
|
|
where basicBlockAnnotationGap(a, succ)
|
|
select a, "Annotated node followed by unannotated $@ in the same basic block", succ,
|
|
succ.getNode().toString()
|