mirror of
https://github.com/github/codeql.git
synced 2026-06-24 14:17:05 +02:00
39e6bfc894
Preparatory refactor for the shared-CFG dataflow migration. Adds the adapter that mediates between the Python AST and the shared codeql.controlflow.ControlFlowGraph signature, plus the test suites that validate the new CFG directly against this adapter. The public facade is added in the following commit. Library additions: - semmle.python.controlflow.internal.AstNodeImpl — wraps Python's Stmt/Expr/Scope/Pattern and adds two synthetic kinds of node (BlockStmt for body slots, intermediate nodes for multi-operand boolean expressions) to satisfy the shared CFG signature. - lib/printCfgNew.ql — debug/visualisation query for the new CFG. - consistency-queries/CfgConsistency.ql — consistency query running the shared CFG's standard checks against Python. Test additions (all driven directly off AstNodeImpl): - ControlFlow/bindings/* — annotation-driven SSA-binding tests (annassign, compound, comprehension, decorated, except_handler, imports, match_pattern, parameters, simple, type_params, walrus_starred, with_stmt, dead_under_no_raise). - ControlFlow/evaluation-order/NewCfg*.ql — mirrors of the existing OldCfg evaluation-order self-validation suite, run against the new CFG via NewCfgImpl.qll. - Minor extensions to existing test_if.py / test_boolean.py + cosmetic .expected churn on a handful of OldCfg tests. No dataflow, SSA, or production query is migrated yet. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
33 lines
1.2 KiB
Plaintext
33 lines
1.2 KiB
Plaintext
/**
|
|
* Phase -1 of the dataflow CFG migration: verifies that every variable
|
|
* binding visible to the AST (`Name.defines(v)`) corresponds to a CFG node
|
|
* in the new CFG (`semmle.python.controlflow.internal.AstNodeImpl`).
|
|
*
|
|
* The expected tag is `cfgdefines=<name>`. Each binding annotation in the
|
|
* test sources looks like `# $ cfgdefines=x` for a binding currently
|
|
* covered by the new CFG, or `# $ MISSING: cfgdefines=x` for a binding
|
|
* that is known to be uncovered (a "red" test case that should be
|
|
* green-flipped once the corresponding `cfg-ext-*` extension lands).
|
|
*/
|
|
|
|
import python
|
|
import semmle.python.controlflow.internal.AstNodeImpl as CfgImpl
|
|
import utils.test.InlineExpectationsTest
|
|
|
|
module CfgBindingsTest implements TestSig {
|
|
string getARelevantTag() { result = "cfgdefines" }
|
|
|
|
predicate hasActualResult(Location location, string element, string tag, string value) {
|
|
exists(Name n, Variable v, CfgImpl::ControlFlowNode cfg |
|
|
n.defines(v) and
|
|
cfg.getAstNode().asExpr() = n and
|
|
location = n.getLocation() and
|
|
element = n.toString() and
|
|
tag = "cfgdefines" and
|
|
value = v.getId()
|
|
)
|
|
}
|
|
}
|
|
|
|
import MakeTest<CfgBindingsTest>
|