Files
codeql/csharp/ql/test/query-tests/Security Features/CWE-285/MissingAccessControl/MVCTests/ProfileController.cs
2025-06-20 11:49:30 +02:00

85 lines
1.8 KiB
C#

using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Authorization;
public class RequirePermissionAttribute : AuthorizeAttribute { }
public class ProfileController : Controller
{
private void doThings() { }
private bool isAuthorized() { return false; }
// BAD: This is a Delete method, but no auth is specified.
public ActionResult Delete1(int id) // $ Alert
{
doThings();
return View();
}
// GOOD: isAuthorized is checked.
public ActionResult Delete2(int id)
{
if (!isAuthorized())
{
return null;
}
doThings();
return View();
}
// GOOD: The Authorize attribute is used.
[Authorize]
public ActionResult Delete3(int id)
{
doThings();
return View();
}
// GOOD: The RequirePermission attribute is used (which extends AuthorizeAttribute).
[RequirePermission]
public ActionResult Delete4(int id)
{
doThings();
return View();
}
// GOOD: The Authorize attribute is used.
[Authorize("foo")]
public ActionResult Delete5(int id)
{
doThings();
return View();
}
}
[Authorize]
public class AuthBaseController : Controller
{
protected void doThings() { }
}
public class SubController : AuthBaseController
{
// GOOD: The Authorize attribute is used on the base class.
public ActionResult Delete4(int id)
{
doThings();
return View();
}
}
[Authorize]
public class AuthBaseGenericController<T> : Controller
{
protected void doThings() { }
}
public class SubGenericController : AuthBaseGenericController<string>
{
// GOOD: The Authorize attribute is used on the base class.
public ActionResult Delete5(int id)
{
doThings();
return View();
}
}