mirror of
https://github.com/github/codeql.git
synced 2026-05-27 17:41:24 +02:00
0742e1e901
Implements `AstSig::Parameter` and `callableGetParameter(c, i)` in
`AstNodeImpl.qll`, following the C# template
(`csharp/.../ControlFlowGraph.qll:147-156`) rather than Java's
`Parameter() { none() }`.
Each Python parameter (positional, *args, keyword-only, **kwargs) now
becomes a CFG node at a stable position in the enclosing callable's
entry sequence. Defaults still evaluate at function-definition time
via `FunctionDefExpr.getDefault` / `LambdaExpr.getDefault`, so
`Parameter::getDefaultValue()` returns `none()` (the shared CFG
library calls this to model the missing-argument fallback, which
Python does not surface at the CFG level).
The bindings test now exercises parameters (the `py_expr_contexts(_, 4, ...)`
exclusion has been removed). A new `parameters.py` test case covers
positional, defaulted, vararg, kwarg, keyword-only, kitchen-sink,
method (self/cls), lambda, and PEP 570 positional-only parameters.
Several other test files were updated to annotate parameters that the
test had previously hidden (synthetic `.0` comprehension parameter,
method `self`, decorator `f`, etc.).
Verified:
- All 24 ControlFlow/evaluation-order tests still pass.
- CFG consistency query (`python/ql/consistency-queries/CfgConsistency.ql`)
shows zero violations on CPython.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
22 lines
690 B
Python
22 lines
690 B
Python
# Comprehension and `for` loop targets — wired in the new CFG.
|
|
# Comprehensions are nested function scopes with a synthetic `.0` parameter
|
|
# bound to the iterable.
|
|
|
|
# Bare-name `for` target.
|
|
for i in range(3): # $ cfgdefines=i
|
|
pass
|
|
|
|
# Compound `for` target.
|
|
for k, v in [(1, 2)]: # $ cfgdefines=k cfgdefines=v
|
|
pass
|
|
|
|
# Comprehension targets.
|
|
_ = [x for x in range(3)] # $ cfgdefines=_ cfgdefines=x cfgdefines=.0
|
|
_ = {y: z for y, z in []} # $ cfgdefines=_ cfgdefines=y cfgdefines=z cfgdefines=.0
|
|
_ = (a for a in []) # $ cfgdefines=_ cfgdefines=a cfgdefines=.0
|
|
|
|
# Nested comprehensions.
|
|
_ = [b for c in [] for b in c] # $ cfgdefines=_ cfgdefines=c cfgdefines=b cfgdefines=.0
|
|
|
|
|