mirror of
https://github.com/github/codeql.git
synced 2026-05-27 17:41:24 +02:00
0742e1e901
Implements `AstSig::Parameter` and `callableGetParameter(c, i)` in
`AstNodeImpl.qll`, following the C# template
(`csharp/.../ControlFlowGraph.qll:147-156`) rather than Java's
`Parameter() { none() }`.
Each Python parameter (positional, *args, keyword-only, **kwargs) now
becomes a CFG node at a stable position in the enclosing callable's
entry sequence. Defaults still evaluate at function-definition time
via `FunctionDefExpr.getDefault` / `LambdaExpr.getDefault`, so
`Parameter::getDefaultValue()` returns `none()` (the shared CFG
library calls this to model the missing-argument fallback, which
Python does not surface at the CFG level).
The bindings test now exercises parameters (the `py_expr_contexts(_, 4, ...)`
exclusion has been removed). A new `parameters.py` test case covers
positional, defaulted, vararg, kwarg, keyword-only, kitchen-sink,
method (self/cls), lambda, and PEP 570 positional-only parameters.
Several other test files were updated to annotate parameters that the
test had previously hidden (synthetic `.0` comprehension parameter,
method `self`, decorator `f`, etc.).
Verified:
- All 24 ControlFlow/evaluation-order tests still pass.
- CFG consistency query (`python/ql/consistency-queries/CfgConsistency.ql`)
shows zero violations on CPython.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
33 lines
1.2 KiB
Plaintext
33 lines
1.2 KiB
Plaintext
/**
|
|
* Phase -1 of the dataflow CFG migration: verifies that every variable
|
|
* binding visible to the AST (`Name.defines(v)`) corresponds to a CFG node
|
|
* in the new CFG (`semmle.python.controlflow.internal.AstNodeImpl`).
|
|
*
|
|
* The expected tag is `cfgdefines=<name>`. Each binding annotation in the
|
|
* test sources looks like `# $ cfgdefines=x` for a binding currently
|
|
* covered by the new CFG, or `# $ MISSING: cfgdefines=x` for a binding
|
|
* that is known to be uncovered (a "red" test case that should be
|
|
* green-flipped once the corresponding `cfg-ext-*` extension lands).
|
|
*/
|
|
|
|
import python
|
|
import semmle.python.controlflow.internal.AstNodeImpl as CfgImpl
|
|
import utils.test.InlineExpectationsTest
|
|
|
|
module CfgBindingsTest implements TestSig {
|
|
string getARelevantTag() { result = "cfgdefines" }
|
|
|
|
predicate hasActualResult(Location location, string element, string tag, string value) {
|
|
exists(Name n, Variable v, CfgImpl::ControlFlowNode cfg |
|
|
n.defines(v) and
|
|
cfg.getAstNode().asExpr() = n and
|
|
location = n.getLocation() and
|
|
element = n.toString() and
|
|
tag = "cfgdefines" and
|
|
value = v.getId()
|
|
)
|
|
}
|
|
}
|
|
|
|
import MakeTest<CfgBindingsTest>
|