mirror of
https://github.com/github/codeql.git
synced 2026-04-27 09:45:15 +02:00
260bfe7b1d
Since `runtimeExprInStaticInitializer` only looks at expressions at the top level of an initializer or directly below some number of top-level aggregate literals, there is no need for `inStaticInitializer` to include expressions strictly below those in the AST. I tested this on Wireshark, which has very large static initializers, but found no measureable difference in run time. There are some differences in tuple counts and iteration counts, though: - `inStaticInitializer` changes from 6,241,153 rows (86 iterations) to 5,031,617 rows (7 iterations). - `runtimeExprInStaticInitializer` changes from 386,350 rows to 4,705 rows. - `hasDynamicInitialization` has 410 rows both before and after, which suggests that this change does not affect results. Even though there is no impact on this snapshot at this time, things might look different if/when the restriction on aggregate literals to 100 children is removed in the extractor.