mirror of
https://github.com/github/codeql.git
synced 2026-07-05 11:35:30 +02:00
I've considered every query in the code-scanning suite (high-precision security queries). Taint-tracking queries made speculative: - java/ql/src/Security/CWE/CWE-022/TaintedPath.ql - java/ql/src/Security/CWE/CWE-022/ZipSlip.ql - java/ql/src/Security/CWE/CWE-023/PartialPathTraversalFromRemote.ql - java/ql/src/Security/CWE/CWE-074/JndiInjection.ql - java/ql/src/Security/CWE/CWE-074/XsltInjection.ql - java/ql/src/Security/CWE/CWE-078/ExecTainted.ql - java/ql/src/Security/CWE/CWE-078/ExecUnescaped.ql - java/ql/src/Security/CWE/CWE-079/XSS.ql - java/ql/src/Security/CWE/CWE-089/SqlTainted.ql - java/ql/src/Security/CWE/CWE-090/LdapInjection.ql - java/ql/src/Security/CWE/CWE-094/GroovyInjection.ql - java/ql/src/Security/CWE/CWE-094/InsecureBeanValidation.ql - java/ql/src/Security/CWE/CWE-094/JexlInjection.ql - java/ql/src/Security/CWE/CWE-094/MvelInjection.ql - java/ql/src/Security/CWE/CWE-094/SpelInjection.ql - java/ql/src/Security/CWE/CWE-094/TemplateInjection.ql - java/ql/src/Security/CWE/CWE-113/ResponseSplitting.ql - java/ql/src/Security/CWE/CWE-1204/StaticInitializationVector.ql - java/ql/src/Security/CWE/CWE-134/ExternallyControlledFormatString.ql - java/ql/src/Security/CWE/CWE-266/IntentUriPermissionManipulation.ql - java/ql/src/Security/CWE/CWE-327/BrokenCryptoAlgorithm.ql - java/ql/src/Security/CWE/CWE-330/InsecureRandomness.ql - java/ql/src/Security/CWE/CWE-441/UnsafeContentUriResolution.ql - java/ql/src/Security/CWE/CWE-470/FragmentInjection.ql - java/ql/src/Security/CWE/CWE-502/UnsafeDeserialization.ql - java/ql/src/Security/CWE/CWE-522/InsecureLdapAuth.ql - java/ql/src/Security/CWE/CWE-552/UrlForward.ql - java/ql/src/Security/CWE/CWE-601/UrlRedirect.ql - java/ql/src/Security/CWE/CWE-611/XXE.ql - java/ql/src/Security/CWE/CWE-643/XPathInjection.ql - java/ql/src/Security/CWE/CWE-681/NumericCastTainted.ql - java/ql/src/Security/CWE/CWE-730/PolynomialReDoS.ql - java/ql/src/Security/CWE/CWE-730/RegexInjection.ql - java/ql/src/Security/CWE/CWE-917/OgnlInjection.ql - java/ql/src/Security/CWE/CWE-918/RequestForgery.ql - java/ql/src/Security/CWE/CWE-927/ImplicitPendingIntents.ql - java/ql/src/Security/CWE/CWE-940/AndroidIntentRedirection.ql Skipped because they're problem queries, not path-problem, even though they use taint tracking: - java/ql/src/Security/CWE/CWE-209/StackTraceExposure.ql - java/ql/src/Security/CWE/CWE-312/CleartextStorageCookie.ql - java/ql/src/Security/CWE/CWE-335/PredictableSeed.ql - java/ql/src/Security/CWE/CWE-470/FragmentInjectionInPreferenceActivity.ql - java/ql/src/Security/CWE/CWE-614/InsecureCookie.ql Skipped because they use data flow, not taint tracking - java/ql/src/Security/CWE/CWE-295/InsecureTrustManager.ql - java/ql/src/Security/CWE/CWE-297/UnsafeHostnameVerification.ql - java/ql/src/Security/CWE/CWE-326/InsufficientKeySize.ql - java/ql/src/Security/CWE/CWE-335/PredictableSeed.ql - java/ql/src/Security/CWE/CWE-347/MissingJWTSignatureCheck.ql - java/ql/src/Security/CWE/CWE-489/WebviewDebuggingEnabled.ql - java/ql/src/Security/CWE/CWE-614/InsecureCookie.ql - java/ql/src/Security/CWE/CWE-780/RsaWithoutOaep.ql
57 lines
2.1 KiB
Plaintext
57 lines
2.1 KiB
Plaintext
/** Provides taint tracking configurations to be used in queries related to implicit `PendingIntent`s. */
|
|
|
|
import java
|
|
import semmle.code.java.dataflow.TaintTracking
|
|
import semmle.code.java.frameworks.android.Intent
|
|
import semmle.code.java.frameworks.android.PendingIntent
|
|
import semmle.code.java.security.ImplicitPendingIntents
|
|
|
|
/**
|
|
* A taint tracking configuration for implicit `PendingIntent`s
|
|
* being wrapped in another implicit `Intent` that gets started.
|
|
*/
|
|
module ImplicitPendingIntentStartConfig implements DataFlow::StateConfigSig {
|
|
class FlowState = PendingIntentState;
|
|
|
|
predicate isSource(DataFlow::Node source, FlowState state) {
|
|
source instanceof ImplicitPendingIntentSource and state instanceof NoState
|
|
}
|
|
|
|
predicate isSink(DataFlow::Node sink, FlowState state) {
|
|
sink instanceof ImplicitPendingIntentSink and state instanceof MutablePendingIntent
|
|
}
|
|
|
|
predicate isBarrier(DataFlow::Node sanitizer) { sanitizer instanceof ExplicitIntentSanitizer }
|
|
|
|
predicate isAdditionalFlowStep(DataFlow::Node node1, DataFlow::Node node2) {
|
|
any(ImplicitPendingIntentAdditionalTaintStep c).step(node1, node2)
|
|
}
|
|
|
|
predicate isAdditionalFlowStep(
|
|
DataFlow::Node node1, FlowState state1, DataFlow::Node node2, FlowState state2
|
|
) {
|
|
any(ImplicitPendingIntentAdditionalTaintStep c).mutablePendingIntentCreation(node1, node2) and
|
|
state1 instanceof NoState and
|
|
state2 instanceof MutablePendingIntent
|
|
}
|
|
|
|
predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet c) {
|
|
isSink(node, _) and
|
|
allowIntentExtrasImplicitRead(node, c)
|
|
or
|
|
isAdditionalFlowStep(node, _) and
|
|
c.(DataFlow::FieldContent).getType() instanceof PendingIntent
|
|
or
|
|
// Allow implicit reads of Intent arrays for steps like getActivities
|
|
// or sinks like startActivities
|
|
(isSink(node, _) or isAdditionalFlowStep(node, _, _, _)) and
|
|
node.getType().(Array).getElementType() instanceof TypeIntent and
|
|
c instanceof DataFlow::ArrayContent
|
|
}
|
|
|
|
predicate observeDiffInformedIncrementalMode() { any() }
|
|
}
|
|
|
|
module ImplicitPendingIntentStartFlow =
|
|
TaintTracking::SpeculativeGlobalWithState<ImplicitPendingIntentStartConfig, speculativity/0>;
|