mirror of
https://github.com/github/codeql.git
synced 2026-02-26 20:03:51 +01:00
5b63b4957c
Mostly just adding `private import LegacyPointsTo`. Sometimes getting rid of other imports that are superceded by that module.
24 lines
737 B
Plaintext
24 lines
737 B
Plaintext
/**
|
|
* @name Class should be a context manager
|
|
* @description Making a class a context manager allows instances to be used in a 'with' statement.
|
|
* This improves resource handling and code readability.
|
|
* @kind problem
|
|
* @tags quality
|
|
* maintainability
|
|
* readability
|
|
* performance
|
|
* @problem.severity recommendation
|
|
* @sub-severity high
|
|
* @precision medium
|
|
* @id py/should-be-context-manager
|
|
*/
|
|
|
|
import python
|
|
private import LegacyPointsTo
|
|
|
|
from ClassValue c
|
|
where not c.isBuiltin() and not c.isContextManager() and exists(c.declaredAttribute("__del__"))
|
|
select c,
|
|
"Class " + c.getName() +
|
|
" implements __del__ (presumably to release some resource). Consider making it a context manager."
|