mirror of
https://github.com/github/codeql.git
synced 2025-12-16 16:53:25 +01:00
5b63b4957c
Mostly just adding `private import LegacyPointsTo`. Sometimes getting rid of other imports that are superceded by that module.
28 lines
817 B
Plaintext
28 lines
817 B
Plaintext
/**
|
|
* @name Non-portable comparison using is when operands support `__eq__`
|
|
* @description Comparison using 'is' when equivalence is not the same as identity and may not be portable.
|
|
* @kind problem
|
|
* @tags quality
|
|
* reliability
|
|
* correctness
|
|
* @problem.severity recommendation
|
|
* @sub-severity low
|
|
* @precision medium
|
|
* @id py/comparison-using-is-non-portable
|
|
*/
|
|
|
|
import python
|
|
import IsComparisons
|
|
private import LegacyPointsTo
|
|
|
|
from Compare comp, Cmpop op, ClassValue c
|
|
where
|
|
invalid_portable_is_comparison(comp, op, c) and
|
|
exists(Expr sub | sub = comp.getASubExpression() |
|
|
cpython_interned_constant(sub) and
|
|
not universally_interned_constant(sub)
|
|
)
|
|
select comp,
|
|
"The result of this comparison with '" + op.getSymbol() +
|
|
"' may differ between implementations of Python."
|