mirror of
https://github.com/github/codeql.git
synced 2025-12-20 02:44:30 +01:00
This commit removes SSA nodes from the data flow graph. Specifically, for a definition and use such as ```python x = expr y = x + 2 ``` we used to have flow from `expr` to an SSA variable representing x and from that SSA variable to the use of `x` in the definition of `y`. Now we instead have flow from `expr` to the control flow node for `x` at line 1 and from there to the control flow node for `x` at line 2. Specific changes: - `EssaNode` from the data flow layer no longer exists. - Several glue steps between `EssaNode`s and `CfgNode`s have been deleted. - Entry nodes are now admitted as `CfgNodes` in the data flow layer (they were filtered out before). - Entry nodes now have a new `toString` taking into account that the module name may be ambigous. - Some tests have been rewritten to accomodate the changes, but only `python/ql/test/experimental/dataflow/basic/maximalFlowsConfig.qll` should have semantic changes. - Comments have been updated - Test output has been updated, but apart from `python/ql/test/experimental/dataflow/basic/maximalFlows.expected` only `python/ql/test/experimental/dataflow/typetracking-summaries/summaries.py` should have a semantic change. This is a bonus fix, probably meaning that something was never connected up correctly.
73 lines
1.6 KiB
Python
73 lines
1.6 KiB
Python
# Python 3 specific tests, like the one in coverage/classes.py
|
|
#
|
|
# User-defined methods, both instance methods and class methods, can be called in many non-standard ways
|
|
# i.e. differently from simply `c.f()` or `C.f()`. For example, a user-defined `__await__` method on a
|
|
# class `C` will be called by the syntactic construct `await c` when `c` is an instance of `C`.
|
|
#
|
|
# These tests should cover all the class calls that we hope to support.
|
|
# It is based on https://docs.python.org/3/reference/datamodel.html, and headings refer there.
|
|
#
|
|
# All functions starting with "test_" should run and execute `print("OK")` exactly once.
|
|
# This can be checked by running validTest.py.
|
|
|
|
import sys
|
|
import os
|
|
|
|
sys.path.append(os.path.dirname(os.path.dirname((__file__))))
|
|
from testlib import expects
|
|
|
|
|
|
def SINK1(x):
|
|
pass
|
|
|
|
|
|
def SINK2(x):
|
|
pass
|
|
|
|
|
|
def SINK3(x):
|
|
pass
|
|
|
|
|
|
def SINK4(x):
|
|
pass
|
|
|
|
|
|
def OK():
|
|
print("OK")
|
|
|
|
|
|
|
|
# 3.3.7. Emulating container types
|
|
|
|
# object.__length_hint__(self)
|
|
class With_length_hint:
|
|
def __length_hint__(self):
|
|
SINK1(self)
|
|
OK()
|
|
return 0
|
|
|
|
|
|
def test_length_hint():
|
|
import operator
|
|
|
|
with_length_hint = With_length_hint() #$ arg1="with_length_hint" func=With_length_hint.__length_hint__
|
|
operator.length_hint(with_length_hint)
|
|
|
|
|
|
# 3.3.8. Emulating numeric types
|
|
|
|
# object.__index__(self)
|
|
class With_index:
|
|
def __index__(self):
|
|
SINK1(self)
|
|
OK() # Call not found
|
|
return 0
|
|
|
|
|
|
def test_index():
|
|
import operator
|
|
|
|
with_index = With_index() #$ arg1="with_index" func=With_index.__index__
|
|
operator.index(with_index)
|