Files
codeql/javascript/ql/src/AngularJS/DoubleCompilation.ql
2019-01-07 10:15:45 +00:00

27 lines
885 B
Plaintext

/**
* @name Double compilation
* @description Recompiling an already compiled part of the DOM can lead to
* unexpected behavior of directives, performance problems, and memory leaks.
* @kind problem
* @problem.severity warning
* @id js/angular/double-compilation
* @tags reliability
* frameworks/angularjs
* @precision very-high
*/
import javascript
from AngularJS::ServiceReference compile, SimpleParameter elem, CallExpr c
where
compile.getName() = "$compile" and
elem = any(AngularJS::CustomDirective d)
.getALinkFunction()
.(AngularJS::LinkFunction)
.getElementParameter() and
c = compile.getACall() and
c.getArgument(0).mayReferToParameter(elem) and
// don't flag $compile calls that specify a `maxPriority`
c.getNumArgument() < 3
select c, "This call to $compile may cause double compilation of '" + elem + "'."