mirror of
https://github.com/github/codeql.git
synced 2026-06-21 21:01:13 +02:00
3c9b0f770b
Flips the Python dataflow trunk from the legacy CFG (semmle/python/Flow.qll) and legacy ESSA SSA (semmle/python/essa/*) to the new shared CFG facade (semmle.python.controlflow.internal.Cfg) and the new SSA adapter (semmle.python.dataflow.new.internal.SsaImpl), both introduced additively in the preceding PRs in this stack. This is the trunk-flip equivalent of the original draft PR #21894 (kept around as documentation), rebased on top of the four preparatory PRs: P1: Remove AstNode.getAFlowNode() and rewrite callers (#21919). P2: Qualify Flow.qll's AST references with Py:: prefix (#21920). P3: Add new shared-CFG-backed control flow graph (#21921). P4: Add new shared-SSA-backed SSA adapter (#21923). The Python dataflow library (semmle/python/dataflow/new/) now imports the new CFG facade and SSA adapter. All CFG-typed predicates (ControlFlowNode, CallNode, BasicBlock, NameNode, AttrNode, ...) are qualified with the Cfg:: prefix; SSA references switch from EssaVariable/EssaDefinition to SsaImpl::Definition/SourceVariable. GuardNode is redesigned to use the new CFG's outcome-node model (isAfterTrue / isAfterFalse) instead of the legacy ConditionBlock + flipped indirection. Only BarrierGuard<...> is preserved as public API. Framework files (Bottle, FastApi, Django, Tornado, Pyramid, Stdlib, ...) are updated to take CFG nodes from the new facade. A handful of dataflow consistency tweaks for the new CFG: - Augmented-assignment targets are treated as both load and store. - 'from X import *' produces uncertain SSA writes for unknown names. - CFG nodes are canonicalised so dataflow does not see equivalent pre/post-order pairs as distinct nodes. Two AST tweaks for the new CFG: - AstNodeImpl: omit PEP 695 type-parameter names from FunctionDefExpr / ClassDefExpr children. - ImportResolution: drop the legacy essa import. Test churn (~175 files): reblessed library- and query-test .expected files reflect slightly different CFG granularity, different toString output, and a handful of true alert deltas in security queries. Verification: all 367 lib + src + consistency-queries compile clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
76 lines
6.2 KiB
Plaintext
76 lines
6.2 KiB
Plaintext
edges
|
|
| test.py:5:26:5:32 | After ImportMember | test.py:5:26:5:32 | request | provenance | |
|
|
| test.py:5:26:5:32 | request | test.py:13:16:13:22 | request | provenance | |
|
|
| test.py:5:26:5:32 | request | test.py:23:16:23:22 | request | provenance | |
|
|
| test.py:5:26:5:32 | request | test.py:34:12:34:18 | request | provenance | |
|
|
| test.py:5:26:5:32 | request | test.py:42:12:42:18 | request | provenance | |
|
|
| test.py:5:26:5:32 | request | test.py:54:12:54:18 | request | provenance | |
|
|
| test.py:13:5:13:12 | data_raw | test.py:14:5:14:8 | data | provenance | Decoding-Base64 |
|
|
| test.py:13:16:13:22 | request | test.py:13:16:13:27 | After Attribute | provenance | AdditionalTaintStep |
|
|
| test.py:13:16:13:27 | After Attribute | test.py:13:16:13:39 | After Attribute() | provenance | dict.get |
|
|
| test.py:13:16:13:39 | After Attribute() | test.py:13:5:13:12 | data_raw | provenance | |
|
|
| test.py:14:5:14:8 | data | test.py:15:36:15:39 | data | provenance | |
|
|
| test.py:23:5:23:12 | data_raw | test.py:24:5:24:8 | data | provenance | Decoding-Base64 |
|
|
| test.py:23:16:23:22 | request | test.py:23:16:23:27 | After Attribute | provenance | AdditionalTaintStep |
|
|
| test.py:23:16:23:27 | After Attribute | test.py:23:16:23:39 | After Attribute() | provenance | dict.get |
|
|
| test.py:23:16:23:39 | After Attribute() | test.py:23:5:23:12 | data_raw | provenance | |
|
|
| test.py:24:5:24:8 | data | test.py:25:44:25:47 | data | provenance | |
|
|
| test.py:34:5:34:8 | data | test.py:35:10:35:13 | data | provenance | |
|
|
| test.py:34:5:34:8 | data | test.py:36:13:36:16 | data | provenance | |
|
|
| test.py:34:12:34:18 | request | test.py:34:12:34:23 | After Attribute | provenance | AdditionalTaintStep |
|
|
| test.py:34:12:34:23 | After Attribute | test.py:34:12:34:35 | After Attribute() | provenance | dict.get |
|
|
| test.py:34:12:34:35 | After Attribute() | test.py:34:5:34:8 | data | provenance | |
|
|
| test.py:42:5:42:8 | data | test.py:43:22:43:25 | data | provenance | |
|
|
| test.py:42:5:42:8 | data | test.py:44:25:44:28 | data | provenance | |
|
|
| test.py:42:12:42:18 | request | test.py:42:12:42:23 | After Attribute | provenance | AdditionalTaintStep |
|
|
| test.py:42:12:42:23 | After Attribute | test.py:42:12:42:35 | After Attribute() | provenance | dict.get |
|
|
| test.py:42:12:42:35 | After Attribute() | test.py:42:5:42:8 | data | provenance | |
|
|
| test.py:47:17:47:19 | arg | test.py:50:32:50:34 | arg | provenance | |
|
|
| test.py:54:5:54:8 | data | test.py:55:17:55:20 | data | provenance | |
|
|
| test.py:54:12:54:18 | request | test.py:54:12:54:23 | After Attribute | provenance | AdditionalTaintStep |
|
|
| test.py:54:12:54:23 | After Attribute | test.py:54:12:54:35 | After Attribute() | provenance | dict.get |
|
|
| test.py:54:12:54:35 | After Attribute() | test.py:54:5:54:8 | data | provenance | |
|
|
| test.py:55:17:55:20 | data | test.py:47:17:47:19 | arg | provenance | |
|
|
nodes
|
|
| test.py:5:26:5:32 | After ImportMember | semmle.label | After ImportMember |
|
|
| test.py:5:26:5:32 | request | semmle.label | request |
|
|
| test.py:13:5:13:12 | data_raw | semmle.label | data_raw |
|
|
| test.py:13:16:13:22 | request | semmle.label | request |
|
|
| test.py:13:16:13:27 | After Attribute | semmle.label | After Attribute |
|
|
| test.py:13:16:13:39 | After Attribute() | semmle.label | After Attribute() |
|
|
| test.py:14:5:14:8 | data | semmle.label | data |
|
|
| test.py:15:36:15:39 | data | semmle.label | data |
|
|
| test.py:23:5:23:12 | data_raw | semmle.label | data_raw |
|
|
| test.py:23:16:23:22 | request | semmle.label | request |
|
|
| test.py:23:16:23:27 | After Attribute | semmle.label | After Attribute |
|
|
| test.py:23:16:23:39 | After Attribute() | semmle.label | After Attribute() |
|
|
| test.py:24:5:24:8 | data | semmle.label | data |
|
|
| test.py:25:44:25:47 | data | semmle.label | data |
|
|
| test.py:34:5:34:8 | data | semmle.label | data |
|
|
| test.py:34:12:34:18 | request | semmle.label | request |
|
|
| test.py:34:12:34:23 | After Attribute | semmle.label | After Attribute |
|
|
| test.py:34:12:34:35 | After Attribute() | semmle.label | After Attribute() |
|
|
| test.py:35:10:35:13 | data | semmle.label | data |
|
|
| test.py:36:13:36:16 | data | semmle.label | data |
|
|
| test.py:42:5:42:8 | data | semmle.label | data |
|
|
| test.py:42:12:42:18 | request | semmle.label | request |
|
|
| test.py:42:12:42:23 | After Attribute | semmle.label | After Attribute |
|
|
| test.py:42:12:42:35 | After Attribute() | semmle.label | After Attribute() |
|
|
| test.py:43:22:43:25 | data | semmle.label | data |
|
|
| test.py:44:25:44:28 | data | semmle.label | data |
|
|
| test.py:47:17:47:19 | arg | semmle.label | arg |
|
|
| test.py:50:32:50:34 | arg | semmle.label | arg |
|
|
| test.py:54:5:54:8 | data | semmle.label | data |
|
|
| test.py:54:12:54:18 | request | semmle.label | request |
|
|
| test.py:54:12:54:23 | After Attribute | semmle.label | After Attribute |
|
|
| test.py:54:12:54:35 | After Attribute() | semmle.label | After Attribute() |
|
|
| test.py:55:17:55:20 | data | semmle.label | data |
|
|
subpaths
|
|
#select
|
|
| test.py:15:36:15:39 | data | test.py:5:26:5:32 | After ImportMember | test.py:15:36:15:39 | data | Call to hmac.new [position 1] with untrusted data from $@. | test.py:5:26:5:32 | After ImportMember | After ImportMember |
|
|
| test.py:25:44:25:47 | data | test.py:5:26:5:32 | After ImportMember | test.py:25:44:25:47 | data | Call to hmac.new [keyword msg] with untrusted data from $@. | test.py:5:26:5:32 | After ImportMember | After ImportMember |
|
|
| test.py:35:10:35:13 | data | test.py:5:26:5:32 | After ImportMember | test.py:35:10:35:13 | data | Call to unknown.lib.func [position 0] with untrusted data from $@. | test.py:5:26:5:32 | After ImportMember | After ImportMember |
|
|
| test.py:36:13:36:16 | data | test.py:5:26:5:32 | After ImportMember | test.py:36:13:36:16 | data | Call to unknown.lib.func [keyword kw] with untrusted data from $@. | test.py:5:26:5:32 | After ImportMember | After ImportMember |
|
|
| test.py:43:22:43:25 | data | test.py:5:26:5:32 | After ImportMember | test.py:43:22:43:25 | data | Call to unknown.lib.func [position 0] with untrusted data from $@. | test.py:5:26:5:32 | After ImportMember | After ImportMember |
|
|
| test.py:44:25:44:28 | data | test.py:5:26:5:32 | After ImportMember | test.py:44:25:44:28 | data | Call to unknown.lib.func [keyword kw] with untrusted data from $@. | test.py:5:26:5:32 | After ImportMember | After ImportMember |
|