mirror of
https://github.com/github/codeql.git
synced 2026-02-18 07:53:43 +01:00
Although this is a breaking change, as explained in the change-note, it should onyl affect peopel that have created their own HTTP client request modeling, which I assume is none. The alternative would have been to keep the old class/module as deprecated, and introduce a `HTTP::Client::Requestv2` class/module that is based on `DataFlow::Node` instead. The old class could then be deprecated in 1 year, and we could do a rename from `HTTP::Client::Requestv2` -> `HTTP::Client::Request` at the same time. (and then wait 1 more year before being able to delete `HTTP::Client::Requestv2`) All in all, I think this is the right tradeoff, given that CodeQL Ruby is still in beta.