mirror of
https://github.com/github/codeql.git
synced 2025-12-19 18:33:16 +01:00
07bd85e9fa
The configuration in `DefaultOptions.qll` assumed that a call to any top-level function named `error` would exit the program. This is not true. The assumption was probably about `error(3)`, which is a GNU extension. It only exits if its first argument it not 0. Furthermore, projects such as openssh may define their own function named `error` with different behaviour. Because the GNU `error` function is non-standard, it's perfectly fine to shadow it with a project-specific definition. This change removes two FPs from `PointlessComparison.qll` on https://github.com/openssh/openssh-portable.