mirror of
https://github.com/github/codeql.git
synced 2026-08-04 01:13:00 +02:00
Switches the trunk dataflow library and all in-tree consumers
(frameworks, ApiGraphs, Concepts, regexp, security customisations,
test harness) from the legacy Flow.qll/ESSA stack to the new
shared-CFG facade (Cfg.qll) and the ESSA-shaped adapter on the
shared-SSA library (SsaImpl.qll).
Highlights:
* DataFlowPublic/Private/Dispatch, Attributes, VariableCapture,
IterableUnpacking, ImportResolution, ImportStar, LocalSources,
TaintTrackingPrivate, MatchUnpacking, TypeTrackingImpl,
SsaImpl, Builtins all now qualify CFG/SSA references with
Cfg:: / SsaImpl:: and stop pulling in semmle.python.essa.*.
* AstNodeImpl.qll/Cfg.qll: ImportMember exposes its inner
ImportExpr, DefinitionNode.getValue covers Alias / AnnAssign /
AugAssign / AssignExpr / For-target / Parameter-default,
ForNode is treated as an expression node, AnnotatedExitNode is
canonical, and BoolExprNode.getAnOperand drops the dominance
constraint that did not hold for short-circuit BBs.
* SsaImpl.qll: parameters always get a ParameterDefinition (so
unused parameters still have SSA defs), scope-entry defs for
module globals require an actual store somewhere, scope-exit
has a synthetic use so reaching-defs survives to module
boundary, and the legacy SsaSourceVariable / EssaVariable
surface (getName, getScope, getAUse, getASourceUse,
getAnImplicitUse) is reinstated for downstream queries.
* DataFlowPublic.qll: GuardNode redesigned around the new
structural outcome nodes (isAfterTrue / isAfterFalse). The
legacy ConditionBlock + flipped indirection is gone;
controlsBlock walks UP through 'not' / '==True' / 'is False'
etc. via outcomeOfGuard, accumulating polarity cleanly. Only
BarrierGuard<...> is preserved as public API.
* ModuleVariableNode.getAWrite and LocalFlow::definitionFlowStep
bypass SSA and consult Cfg::NameNode.defines /
Cfg::DefinitionNode.getValue directly, so that write defs
pruned by shared SSA (because the variable has no in-scope
read) still produce dataflow steps.
* Frameworks + downstream consumers: replace
EssaVariable.hasDefiningNode, getAReturnValueFlowNode,
Parameter.getDefault, Scope.getEntryNode / getANormalExit etc.
with CFG-side bridges through Cfg::ControlFlowNode.
The legacy Flow.qll / Essa.qll stack is untouched and remains
available for queries that import it directly.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
248 lines
7.8 KiB
Plaintext
248 lines
7.8 KiB
Plaintext
overlay[local?]
|
|
module;
|
|
|
|
private import python
|
|
private import semmle.python.controlflow.internal.Cfg as Cfg
|
|
private import semmle.python.dataflow.new.FlowSummary
|
|
private import semmle.python.ApiGraphs
|
|
|
|
/**
|
|
* This module ensures that the `callStep` predicate in
|
|
* our type tracker implelemtation does not refer to the
|
|
* `getACall` predicate on `SummarizedCallable`.
|
|
*/
|
|
module RecursionGuard {
|
|
private import semmle.python.dataflow.new.internal.TypeTrackingImpl::TypeTrackingInput as TT
|
|
|
|
private class RecursionGuard extends SummarizedCallable::Range {
|
|
RecursionGuard() { this = "RecursionGuard" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result.getFunction().asCfgNode().(Cfg::NameNode).getId() = this and
|
|
(TT::callStep(_, _) implies any())
|
|
}
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
none()
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() { result.asExpr().(Name).getId() = this }
|
|
}
|
|
}
|
|
|
|
private class SummarizedCallableIdentity extends SummarizedCallable::Range {
|
|
SummarizedCallableIdentity() { this = "identity" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result.getFunction().asCfgNode().(Cfg::NameNode).getId() = this
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() { result.asExpr().(Name).getId() = this }
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
input = "Argument[0]" and
|
|
output = "ReturnValue" and
|
|
preservesValue = true
|
|
}
|
|
}
|
|
|
|
// For lambda flow to work, implement lambdaCall and lambdaCreation
|
|
private class SummarizedCallableApplyLambda extends SummarizedCallable::Range {
|
|
SummarizedCallableApplyLambda() { this = "apply_lambda" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result.getFunction().asCfgNode().(Cfg::NameNode).getId() = this
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() { result.asExpr().(Name).getId() = this }
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
input = "Argument[1]" and
|
|
output = "Argument[0].Parameter[0]" and
|
|
preservesValue = true
|
|
or
|
|
input = "Argument[0].ReturnValue" and
|
|
output = "ReturnValue" and
|
|
preservesValue = true
|
|
}
|
|
}
|
|
|
|
private class SummarizedCallableReversed extends SummarizedCallable::Range {
|
|
SummarizedCallableReversed() { this = "list_reversed" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result.getFunction().asCfgNode().(Cfg::NameNode).getId() = this
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() { result.asExpr().(Name).getId() = this }
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
input = "Argument[0].ListElement" and
|
|
output = "ReturnValue.ListElement" and
|
|
preservesValue = true
|
|
}
|
|
}
|
|
|
|
private class SummarizedCallableMap extends SummarizedCallable::Range {
|
|
SummarizedCallableMap() { this = "list_map" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result.getFunction().asCfgNode().(Cfg::NameNode).getId() = this
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() { result.asExpr().(Name).getId() = this }
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
input = "Argument[1].ListElement" and
|
|
output = "Argument[0].Parameter[0]" and
|
|
preservesValue = true
|
|
or
|
|
input = "Argument[0].ReturnValue" and
|
|
output = "ReturnValue.ListElement" and
|
|
preservesValue = true
|
|
}
|
|
}
|
|
|
|
private class SummarizedCallableAppend extends SummarizedCallable::Range {
|
|
SummarizedCallableAppend() { this = "append_to_list" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result.getFunction().asCfgNode().(Cfg::NameNode).getId() = this
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() { result.asExpr().(Name).getId() = this }
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
input = "Argument[0]" and
|
|
output = "ReturnValue" and
|
|
preservesValue = false
|
|
or
|
|
input = "Argument[1]" and
|
|
output = "ReturnValue.ListElement" and
|
|
preservesValue = true
|
|
}
|
|
}
|
|
|
|
private class SummarizedCallableJsonLoads extends SummarizedCallable::Range {
|
|
SummarizedCallableJsonLoads() { this = "json.loads" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result = API::moduleImport("json").getMember("loads").getACall()
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() {
|
|
result = API::moduleImport("json").getMember("loads").getAValueReachableFromSource()
|
|
}
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
input = "Argument[0]" and
|
|
output = "ReturnValue.ListElement" and
|
|
preservesValue = true
|
|
}
|
|
}
|
|
|
|
// Repeated summaries
|
|
private class SummarizedCallableWithSubpath extends SummarizedCallable::Range {
|
|
SummarizedCallableWithSubpath() { this = "extracted_package.functions.with_subpath" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result =
|
|
API::moduleImport("extracted_package")
|
|
.getMember("functions")
|
|
.getMember("with_subpath")
|
|
.getACall()
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() {
|
|
result =
|
|
API::moduleImport("extracted_package")
|
|
.getMember("functions")
|
|
.getMember("with_subpath")
|
|
.getAValueReachableFromSource()
|
|
}
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
input = "Argument[0]" and
|
|
output = "ReturnValue" and
|
|
preservesValue = false
|
|
}
|
|
}
|
|
|
|
private class SummarizedCallableWithSubpathAgain extends SummarizedCallable::Range {
|
|
SummarizedCallableWithSubpathAgain() { this = "extracted_package.functions.with_subpathII" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result =
|
|
API::moduleImport("extracted_package")
|
|
.getMember("functions")
|
|
.getMember("with_subpath")
|
|
.getACall()
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() {
|
|
result =
|
|
API::moduleImport("extracted_package")
|
|
.getMember("functions")
|
|
.getMember("with_subpath")
|
|
.getAValueReachableFromSource()
|
|
}
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
input = "Argument[0]" and
|
|
output = "ReturnValue.Attribute[pattern]" and
|
|
preservesValue = true
|
|
}
|
|
}
|
|
|
|
private class SummarizedCallableWithoutSubpath extends SummarizedCallable::Range {
|
|
SummarizedCallableWithoutSubpath() { this = "extracted_package.functions.without_subpath" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result =
|
|
API::moduleImport("extracted_package")
|
|
.getMember("functions")
|
|
.getMember("without_subpath")
|
|
.getACall()
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() {
|
|
result =
|
|
API::moduleImport("extracted_package")
|
|
.getMember("functions")
|
|
.getMember("without_subpath")
|
|
.getAValueReachableFromSource()
|
|
}
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
input = "Argument[0]" and
|
|
output = "ReturnValue" and
|
|
preservesValue = false
|
|
}
|
|
}
|
|
|
|
private class SummarizedCallableWithoutSubpathAgain extends SummarizedCallable::Range {
|
|
SummarizedCallableWithoutSubpathAgain() { this = "extracted_package.functions.without_subpathII" }
|
|
|
|
override DataFlow::CallCfgNode getACall() {
|
|
result =
|
|
API::moduleImport("extracted_package")
|
|
.getMember("functions")
|
|
.getMember("without_subpath")
|
|
.getACall()
|
|
}
|
|
|
|
override DataFlow::ArgumentNode getACallback() {
|
|
result =
|
|
API::moduleImport("extracted_package")
|
|
.getMember("functions")
|
|
.getMember("without_subpath")
|
|
.getAValueReachableFromSource()
|
|
}
|
|
|
|
override predicate propagatesFlow(string input, string output, boolean preservesValue) {
|
|
input = "Argument[0]" and
|
|
output = "ReturnValue.Attribute[pattern]" and
|
|
preservesValue = true
|
|
}
|
|
}
|