mirror of
https://github.com/github/codeql.git
synced 2025-12-18 18:10:39 +01:00
10a7294327
This adds Alert annotations for alerts that seem intentional by the test but has not been annotated with 'NOT OK', or the comment was in the wrong place. In a few cases I included 'Source' expectations to make it easier to see what happened. Other 'Source' expectations will be added in bulk a later commit.
80 lines
931 B
JavaScript
80 lines
931 B
JavaScript
function bad1() {
|
|
if (cond1())
|
|
if (cond2())
|
|
return 23;
|
|
else // $ Alert
|
|
return 42;
|
|
}
|
|
|
|
function good1() {
|
|
if (cond1())
|
|
if (cond2())
|
|
return 23;
|
|
else
|
|
return 42;
|
|
}
|
|
|
|
function bad2() {
|
|
if (cond1()) {
|
|
if (cond2()) {
|
|
return 23;
|
|
} else { // $ Alert
|
|
return 42;
|
|
}}
|
|
}
|
|
|
|
function good2() {
|
|
if (cond1())
|
|
if (cond2())
|
|
return 23;
|
|
else
|
|
return 42;
|
|
}
|
|
|
|
function bad3() {
|
|
if (cond1())
|
|
return 23;
|
|
else if (cond2())
|
|
if (cond2())
|
|
return 42;
|
|
else // $ Alert
|
|
return 42;
|
|
}
|
|
|
|
|
|
function good3() {
|
|
if (cond1())
|
|
if (cond2())
|
|
return 23;
|
|
else
|
|
return 42;
|
|
}
|
|
|
|
function good4() {
|
|
if (cond1()) {
|
|
if (cond2())
|
|
return 23;
|
|
} else
|
|
return 42;
|
|
}
|
|
|
|
function good5() {
|
|
if (cond1())
|
|
(function inner() {
|
|
if (cond2())
|
|
return 23;
|
|
else
|
|
return 42;
|
|
}());
|
|
}
|
|
|
|
function good6() {
|
|
if (true) {
|
|
} else if (true) {
|
|
if (true) {
|
|
} else if (true) {
|
|
} else {
|
|
}
|
|
}
|
|
}
|