mirror of
https://github.com/github/codeql.git
synced 2025-12-17 17:23:36 +01:00
48 lines
1.8 KiB
C#
48 lines
1.8 KiB
C#
// semmle-extractor-options: ${testdir}/../../../resources/stubs/System.Web.cs ${testdir}/../../../resources/stubs/System.DirectoryServices.cs /r:System.ComponentModel.Primitives.dll /r:System.Collections.Specialized.dll /r:System.ComponentModel.TypeConverter.dll /r:System.Private.Xml.dll
|
|
|
|
using System;
|
|
using System.DirectoryServices;
|
|
using System.DirectoryServices.Protocols;
|
|
using System.Web;
|
|
using System.Xml;
|
|
|
|
public class LDAPInjectionHandler : IHttpHandler
|
|
{
|
|
public void ProcessRequest(HttpContext ctx)
|
|
{
|
|
string userName = ctx.Request.QueryString["username"];
|
|
|
|
// BAD: Filter includes user input without encoding
|
|
DirectorySearcher ds = new DirectorySearcher("accountname=" + userName);
|
|
DirectorySearcher ds2 = new DirectorySearcher();
|
|
ds.Filter = "accountname=" + userName;
|
|
|
|
// GOOD: Filter includes user input with encoding
|
|
DirectorySearcher ds3 = new DirectorySearcher("accountname=" + LDAPEncode(userName));
|
|
|
|
// BAD: SearchRequest Filter includes user input without encoding
|
|
SearchRequest sr = new SearchRequest();
|
|
sr.Filter = "accountname=" + userName;
|
|
SearchRequest sr2 = new SearchRequest(null, "accountname=" + userName, System.DirectoryServices.Protocols.SearchScope.Base, null);
|
|
|
|
// BAD: Distinguished Name includes user input without encoding
|
|
DirectoryEntry de = new DirectoryEntry("LDAP://Cn=" + userName);
|
|
DirectoryEntry de2 = new DirectoryEntry();
|
|
de2.Path = "LDAP://Cn=" + userName;
|
|
}
|
|
|
|
public string LDAPEncode(string value)
|
|
{
|
|
// Query identifies encoders by method name only, so the body is not important
|
|
return value;
|
|
}
|
|
|
|
public bool IsReusable
|
|
{
|
|
get
|
|
{
|
|
return true;
|
|
}
|
|
}
|
|
}
|