Files
codeql/csharp/ql/test/query-tests/Security Features/CWE-022/TaintedPath/TaintedPath.cs

70 lines
1.8 KiB
C#

// semmle-extractor-options: /r:System.IO.FileSystem.dll /r:System.Runtime.Extensions.dll /r:System.Collections.Specialized.dll ${testdir}/../../../../resources/stubs/System.Web.cs
using System;
using System.IO;
using System.Web;
public class TaintedPathHandler : IHttpHandler
{
public void ProcessRequest(HttpContext ctx)
{
String path = ctx.Request.QueryString["page"];
// BAD: Used via a File.Create... call.
using (StreamWriter sw = File.CreateText(path))
{
sw.WriteLine("Hello");
}
// BAD: Used via StreamWriter constructor
using (StreamWriter sw = new StreamWriter(path))
{
sw.WriteLine("Hello");
}
// BAD: Check is insufficient, text is read.
if (!path.StartsWith("../"))
{
File.ReadAllText(path);
}
// BAD: Check is insufficient, text is read.
if (!string.IsNullOrEmpty(path))
{
File.ReadAllText(path);
}
// BAD: Check is insufficient, text is read.
string badPath = "/home/user/" + path;
if (File.Exists(badPath))
{
ctx.Response.Write(File.ReadAllText(badPath));
}
// GOOD: Tainted path is passed through MapPath
string safePath = ctx.Request.MapPath(path, ctx.Request.ApplicationPath, false);
File.ReadAllText(safePath);
// GOOD: Check against explicit paths
if (path == "foo")
{
File.ReadAllText(path);
}
Directory.Exists(path);
// GOOD: A Guid.
File.ReadAllText(new Guid(path).ToString());
// GOOD: A simple type.
File.ReadAllText(int.Parse(path).ToString());
}
public bool IsReusable
{
get
{
return true;
}
}
}