mirror of
https://github.com/github/codeql.git
synced 2025-12-19 18:33:16 +01:00
97cc0ebc8c
It's a bit crude to suppress all results in instantiations, but we're already using this kind of suppression in `PointlessComparison.ql` (without the `Self`) because there is no convenient alternative. It means we lose some good results but also suppress a new false positive in Boost that surfaced after we added support for non-type template parameters.
23 lines
551 B
C++
23 lines
551 B
C++
struct C1 {
|
|
static const int value = 5;
|
|
};
|
|
|
|
struct C2 {
|
|
static const int value = 6;
|
|
};
|
|
|
|
template<typename T1, typename T2>
|
|
bool compareValues() {
|
|
// Not all instantiations have T1 and T2 equal. Even if that's the case for
|
|
// all instantiations in the program, there could still be more such
|
|
// instantiations outside.
|
|
return
|
|
T1::value < T2::value || // GOOD
|
|
T1::value < T1::value || // BAD [NOT DETECTED]
|
|
C1::value < C1::value ; // BAD
|
|
}
|
|
|
|
bool callCompareValues() {
|
|
return compareValues<C1, C2> || compareValues<C1, C1>();
|
|
}
|