Files
codeql/misc/codegen/test/test_ql.py
Paolo Tranquilli 1dcd60527c Codegen: improve implementation of generated parent/child relationship
This improves the implementation of the generated parent/child
relationship by adding a new `all_children` field to `ql.Class` which
lists all children (both direct and inherited) of a class, carefully
avoiding duplicating children in case of diamond inheritance. This:
* simplifies the generated code,
* avoid children ambiguities in case of diamond inheritance.

This only comes with some changes in the order of children in the
generated tests (we were previously sorting bases alphabetically there).
For the rest this should be a non-functional change.
2025-06-24 17:26:24 +02:00

169 lines
4.2 KiB
Python

import sys
from copy import deepcopy
from misc.codegen.lib import ql
from misc.codegen.test.utils import *
def test_property_has_first_table_param_marked():
tableparams = ["a", "b", "c"]
prop = ql.Property("Prop", "foo", "props", tableparams)
assert prop.tableparams[0].first
assert [p.param for p in prop.tableparams] == tableparams
indefinite_getters = [
("Argument", "getAnArgument"),
("Element", "getAnElement"),
("Integer", "getAnInteger"),
("Operator", "getAnOperator"),
("Unit", "getAUnit"),
("Whatever", "getAWhatever"),
]
@pytest.mark.parametrize("name,expected_getter", indefinite_getters)
def test_property_indefinite_article(name, expected_getter):
prop = ql.Property(name, plural="X")
assert prop.indefinite_getter == expected_getter
@pytest.mark.parametrize("name,expected_getter", indefinite_getters)
def test_property_unordered_getter(name, expected_getter):
prop = ql.Property(name, plural="X", is_unordered=True)
assert prop.getter == expected_getter
@pytest.mark.parametrize(
"plural,expected",
[
(None, False),
("", False),
("X", True),
],
)
def test_property_is_repeated(plural, expected):
prop = ql.Property("foo", "Foo", "props", ["result"], plural=plural)
assert prop.is_repeated is expected
@pytest.mark.parametrize(
"plural,unordered,expected",
[
(None, False, False),
("", False, False),
("X", False, True),
("X", True, False),
],
)
def test_property_is_indexed(plural, unordered, expected):
prop = ql.Property(
"foo", "Foo", "props", ["result"], plural=plural, is_unordered=unordered
)
assert prop.is_indexed is expected
@pytest.mark.parametrize(
"is_optional,is_predicate,plural,expected",
[
(False, False, None, True),
(False, False, "", True),
(False, False, "X", False),
(True, False, None, False),
(False, True, None, False),
],
)
def test_property_is_single(is_optional, is_predicate, plural, expected):
prop = ql.Property(
"foo",
"Foo",
"props",
["result"],
plural=plural,
is_predicate=is_predicate,
is_optional=is_optional,
)
assert prop.is_single is expected
def test_property_no_plural_no_indefinite_getter():
prop = ql.Property("Prop", "Foo", "props", ["result"])
assert prop.indefinite_getter is None
def test_property_getter():
prop = ql.Property("Prop", "Foo")
assert prop.getter == "getProp"
def test_property_predicate_getter():
prop = ql.Property("prop", is_predicate=True)
assert prop.getter == "prop"
def test_class_processes_bases():
bases = ["B", "Ab", "C", "Aa"]
expected = [
ql.Base("B"),
ql.Base("Ab", prev="B"),
ql.Base("C", prev="Ab"),
ql.Base("Aa", prev="C"),
]
cls = ql.Class("Foo", bases=bases)
assert cls.bases == expected
def test_class_has_first_property_marked():
props = [
ql.Property(f"Prop{x}", f"Foo{x}", f"props{x}", [f"{x}"]) for x in range(4)
]
expected = deepcopy(props)
expected[0].first = True
cls = ql.Class("Class", properties=props)
assert cls.properties == expected
def test_root_class():
cls = ql.Class("Class")
assert cls.root
def test_non_root_class():
cls = ql.Class("Class", bases=["A"])
assert not cls.root
def test_class_no_children():
cls = ql.Class(
"Class",
all_children=[],
)
assert cls.has_children is False
def test_class_with_children():
cls = ql.Class(
"Class",
all_children=[ql.Child(ql.Property("Foo", "int"))],
)
assert cls.has_children is True
@pytest.mark.parametrize(
"doc,expected", [(["foo", "bar"], True), (["foo", "bar"], True), ([], False)]
)
def test_has_doc(doc, expected):
stub = ql.Stub("Class", base_import="foo", import_prefix="bar", doc=doc)
assert stub.has_qldoc is expected
def test_synth_accessor_has_first_constructor_param_marked():
params = ["a", "b", "c"]
x = ql.SynthUnderlyingAccessor("foo", "bar", params)
assert x.constructorparams[0].first
assert [p.param for p in x.constructorparams] == params
if __name__ == "__main__":
sys.exit(pytest.main([__file__] + sys.argv[1:]))