mirror of
https://github.com/github/codeql.git
synced 2025-12-18 09:43:15 +01:00
77021ae119
We were mixing between things, so this is just to keep things consistent. Even though it's not strictly needed for all queries, it does look nice I think
41 lines
1.8 KiB
Python
41 lines
1.8 KiB
Python
"""This is adapted from ql/python/ql/test/query-tests\Security\CWE-089
|
|
we now prefer to setup routing by flask
|
|
"""
|
|
|
|
from django.db import connection, models
|
|
from django.db.models.expressions import RawSQL
|
|
from flask import Flask, request
|
|
app = Flask(__name__)
|
|
|
|
class User(models.Model):
|
|
pass
|
|
|
|
@app.route("/users/<username>")
|
|
def show_user(username):
|
|
with connection.cursor() as cursor:
|
|
# GOOD -- Using parameters
|
|
cursor.execute("SELECT * FROM users WHERE username = %s", username)
|
|
User.objects.raw("SELECT * FROM users WHERE username = %s", (username,))
|
|
|
|
# BAD -- Using string formatting
|
|
cursor.execute("SELECT * FROM users WHERE username = '%s'" % username)
|
|
|
|
# BAD -- other ways of executing raw SQL code with string interpolation
|
|
User.objects.annotate(RawSQL("insert into names_file ('name') values ('%s')" % username))
|
|
User.objects.raw("insert into names_file ('name') values ('%s')" % username)
|
|
User.objects.extra("insert into names_file ('name') values ('%s')" % username)
|
|
|
|
# BAD (but currently no custom query to find this)
|
|
#
|
|
# It is exposed to SQL injection (https://docs.djangoproject.com/en/2.2/ref/models/querysets/#extra)
|
|
# For example, using name = "; DROP ALL TABLES -- "
|
|
# will result in SQL: SELECT * FROM name WHERE name = ''; DROP ALL TABLES -- ''
|
|
#
|
|
# This shouldn't be very widespread, since using a normal string will result in invalid SQL
|
|
# Using name = "example", will result in SQL: SELECT * FROM name WHERE name = ''example''
|
|
# which in MySQL will give a syntax error
|
|
#
|
|
# When testing this out locally, none of the queries worked against SQLite3, but I could use
|
|
# the SQL injection against MySQL.
|
|
User.objects.raw("SELECT * FROM users WHERE username = '%s'", (username,))
|