mirror of
https://github.com/github/codeql.git
synced 2025-12-18 09:43:15 +01:00
75873bb4a6
This adds a `NewOrNewArrayExpr.getPlacementPointer` predicate and uses it in `Alloc.qll` to detect when a `new`-expression is not an allocation. User-defined replacements for `operator new` may not be allocations either, but the code continues to assume that they are. It's possible that we want to change this assumption in the future or leave it up to individual queries to decide on which side to err. It's hard to statically tell whether `operator new` has been overloaded in a particular file because it can be overloaded by a definition that is not in scope but is only linked together with that file.
159 lines
2.6 KiB
C++
159 lines
2.6 KiB
C++
|
|
typedef unsigned int size_t;
|
|
void *malloc(size_t size);
|
|
void free(void *ptr);
|
|
|
|
// --- myClass1 ---
|
|
|
|
class myClass1
|
|
{
|
|
public:
|
|
myClass1();
|
|
~myClass1();
|
|
|
|
void method1();
|
|
void method2();
|
|
|
|
private:
|
|
int *array1, *array2, *array3, *array4, *array5, *array6, *array7, *array8;
|
|
};
|
|
|
|
myClass1 :: myClass1()
|
|
{
|
|
array1 = (int *)malloc(sizeof(int) * 100);
|
|
array2 = (int *)malloc(sizeof(int) * 100);
|
|
array3 = (int *)malloc(sizeof(int) * 100);
|
|
array4 = (int *)malloc(sizeof(int) * 100); // never freed
|
|
|
|
free(array1);
|
|
}
|
|
|
|
myClass1 :: ~myClass1()
|
|
{
|
|
free(array2);
|
|
free(array7);
|
|
}
|
|
|
|
void myClass1 :: method1()
|
|
{
|
|
array5 = (int *)malloc(sizeof(int) * 100);
|
|
array6 = (int *)malloc(sizeof(int) * 100);
|
|
array7 = (int *)malloc(sizeof(int) * 100);
|
|
array8 = (int *)malloc(sizeof(int) * 100); // never freed
|
|
|
|
free(array3);
|
|
free(array5);
|
|
}
|
|
|
|
void myClass1 :: method2()
|
|
{
|
|
free(array6);
|
|
}
|
|
|
|
// --- myClass2 ---
|
|
|
|
class myClass2
|
|
{
|
|
public:
|
|
myClass2();
|
|
~myClass2();
|
|
|
|
void method1();
|
|
void method2();
|
|
|
|
private:
|
|
int *array1, *array2, *array3, *array4, *array5, *array6, *array7, *array8;
|
|
};
|
|
|
|
myClass2 :: myClass2()
|
|
{
|
|
array1 = (int *)malloc(sizeof(int) * 100);
|
|
array2 = (int *)malloc(sizeof(int) * 100);
|
|
array3 = (int *)malloc(sizeof(int) * 100);
|
|
array4 = (int *)malloc(sizeof(int) * 100); // never freed
|
|
|
|
free(array1);
|
|
}
|
|
|
|
myClass2 :: ~myClass2()
|
|
{
|
|
free(array2);
|
|
free(array7);
|
|
}
|
|
|
|
void myClass2 :: method1()
|
|
{
|
|
array5 = (int *)malloc(sizeof(int) * 100);
|
|
array6 = (int *)malloc(sizeof(int) * 100);
|
|
array7 = (int *)malloc(sizeof(int) * 100);
|
|
array8 = (int *)malloc(sizeof(int) * 100); // never freed
|
|
|
|
free(array3);
|
|
free(array5);
|
|
}
|
|
|
|
void myClass2 :: method2()
|
|
{
|
|
free(array6);
|
|
}
|
|
|
|
int main()
|
|
{
|
|
{
|
|
myClass1 mc1;
|
|
|
|
mc1.method1();
|
|
mc1.method2();
|
|
}
|
|
|
|
{
|
|
myClass2 *mc2;
|
|
|
|
mc2 = new myClass2();
|
|
mc2->method1();
|
|
mc2->method2();
|
|
delete mc2;
|
|
}
|
|
|
|
{
|
|
void *v1 = malloc(100);
|
|
int *i2 = (int *)malloc(100);
|
|
void *v3 = malloc(100);
|
|
int *i3 = (int *)v3;
|
|
void *v4 = malloc(100);
|
|
|
|
free(v1);
|
|
free(i2);
|
|
free(i3);
|
|
free((int *)v4);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
// --- placement new ---
|
|
|
|
namespace std {
|
|
typedef unsigned long size_t;
|
|
struct nothrow_t {};
|
|
extern const nothrow_t nothrow;
|
|
}
|
|
|
|
void* operator new (std::size_t size, void* ptr) noexcept;
|
|
void* operator new[](std::size_t size, void* ptr) noexcept;
|
|
void* operator new(std::size_t size, const std::nothrow_t&) noexcept;
|
|
void* operator new[](std::size_t size, const std::nothrow_t&) noexcept;
|
|
|
|
int overloadedNew() {
|
|
char buf[sizeof(int)];
|
|
|
|
new(&buf[0]) int(5); // GOOD
|
|
int five = *(int*)buf;
|
|
|
|
new(buf) int[1]; // GOOD
|
|
*(int*)buf = 4;
|
|
|
|
new(std::nothrow) int(3); // BAD
|
|
new(std::nothrow) int[2]; // BAD
|
|
}
|