mirror of
https://github.com/github/codeql.git
synced 2025-12-17 09:13:20 +01:00
We had two 'NOT OK' comments for the same alert. The alert appears on the 'pref' object above.
53 lines
1.4 KiB
JavaScript
53 lines
1.4 KiB
JavaScript
const {BrowserWindow} = require('electron')
|
|
|
|
function test() {
|
|
var unsafe_1 = { // both enabled
|
|
webPreferences: {
|
|
nodeIntegration: true,
|
|
nodeIntegrationInWorker: true,
|
|
plugins: true,
|
|
webSecurity: true,
|
|
sandbox: true
|
|
} // $ Alert
|
|
};
|
|
|
|
var options_1 = { // `nodeIntegrationInWorker` enabled
|
|
webPreferences: {
|
|
plugins: true,
|
|
nodeIntegrationInWorker: false,
|
|
webSecurity: true,
|
|
sandbox: true
|
|
} // $ Alert
|
|
};
|
|
|
|
var pref = { // implicitly enabled
|
|
plugins: true,
|
|
webSecurity: true,
|
|
sandbox: true
|
|
}; // $ Alert
|
|
|
|
var options_2 = {
|
|
webPreferences: pref,
|
|
show: true,
|
|
frame: true,
|
|
minWidth: 300,
|
|
minHeight: 300
|
|
};
|
|
|
|
var safe_used = { // explicitly disabled
|
|
webPreferences: {
|
|
nodeIntegration: false,
|
|
plugins: true,
|
|
webSecurity: true,
|
|
sandbox: true
|
|
}
|
|
};
|
|
|
|
var w1 = new BrowserWindow(unsafe_1);
|
|
var w2 = new BrowserWindow(options_1);
|
|
var w3 = new BrowserWindow(safe_used);
|
|
var w4 = new BrowserWindow({width: 800, height: 600, webPreferences: {nodeIntegration: true}}); // $ Alert - `nodeIntegration` enabled
|
|
var w5 = new BrowserWindow(options_2);
|
|
var w6 = new BrowserWindow(safe_used);
|
|
}
|