mirror of
https://github.com/github/codeql.git
synced 2025-12-18 09:43:15 +01:00
4ef5c9af62
Some files that will change in #1736 have been spared. ./build -j4 target/jars/qlformat find ql/cpp/ql -name "*.ql" -print0 | xargs -0 target/jars/qlformat --input find ql/cpp/ql -name "*.qll" -print0 | xargs -0 target/jars/qlformat --input (cd ql && git checkout 'cpp/ql/src/semmle/code/cpp/ir/implementation/**/*SSA*.qll') buildutils-internal/scripts/pr-checks/sync-identical-files.py --latest
17 lines
430 B
Plaintext
17 lines
430 B
Plaintext
/**
|
|
* @name Equality test on Boolean
|
|
* @description Testing equality with `true` is redundant
|
|
* and can make the code harder to read.
|
|
* @kind problem
|
|
* @problem.severity warning
|
|
*/
|
|
|
|
import cpp
|
|
|
|
from EqualityOperation eq, Expr trueExpr
|
|
where
|
|
trueExpr = eq.getAnOperand() and
|
|
trueExpr.getType() instanceof BoolType and
|
|
trueExpr.getValue().toInt() = 1
|
|
select eq, "Expression tested for equality with 'true'"
|