Files
codeql/ruby/ql/test/query-tests/security/cwe-094/CodeInjection/CodeInjection.rb
2023-02-21 19:26:36 +13:00

115 lines
1.5 KiB
Ruby

require 'active_job'
class UsersController < ActionController::Base
def create
code = params[:code]
# BAD
eval(code)
# BAD
eval(params)
# GOOD - user input is in second argument, which is not evaluated as Ruby code
send(:sanitize, params[:code])
# GOOD
Foo.new.bar(code)
# BAD
Foo.class_eval(code)
# BAD
Foo.module_eval(code)
# GOOD
Bar.class_eval(code)
# BAD
const_get(code)
# BAD
Foo.const_get(code)
# GOOD
Bar.const_get(code)
# BAD
eval(Regexp.escape(code))
# BAD
ActiveJob::Serializers.deserialize(code)
end
def update
# GOOD
eval("foo")
end
private
def sanitize(code)
true
end
end
class Foo
def eval(x)
true
end
def bar(x)
eval(x)
end
end
class Bar
def self.class_eval(x)
true
end
def self.const_get(x)
true
end
end
class UsersController < ActionController::Base
def create
code = params[:code]
obj().send(code, "foo"); # BAD
obj().send("prefix_" + code + "_suffix", "foo"); # GOOD
obj().send("prefix_#{code}_suffix", "foo"); # GOOD
eval("prefix_" + code + "_suffix"); # BAD
eval("prefix_#{code}_suffix"); # BAD
eval(code); # BAD
end
end
Rails.application.routes.draw { resources :posts }
class PostsController < ActionController::Base
before_action :foo
before_action :bar
after_action :baz
def index
end
def foo
@foo = params[:foo]
end
def bar
end
def baz
eval(@foo)
end
end