// Semmle test case for rule SprintfToSqlQuery.ql (Uncontrolled sprintf for SQL query) // Associated with CWE-089: SQL injection. http://cwe.mitre.org/data/definitions/89.html ///// Library routines ///// typedef unsigned long size_t; int snprintf(char *s, size_t n, const char *format, ...); void sanitizeString(char *stringOut, size_t len, const char *strIn); int mysql_query(int arg1, const char *sqlArg); int atoi(const char *nptr); ///// Test code ///// int main(int argc, char** argv) { char *userName = argv[2]; int userNumber = atoi(argv[3]); // a string from the user is injected directly into an SQL query. char query1[1000] = {0}; snprintf(query1, 1000, "SELECT UID FROM USERS where name = \"%s\"", userName); mysql_query(0, query1); // BAD // the user string is encoded by a library routine. char userNameSanitized[1000] = {0}; sanitizeString(userNameSanitized, 1000, userName); char query2[1000] = {0}; snprintf(query2, 1000, "SELECT UID FROM USERS where name = \"%s\"", userNameSanitized); mysql_query(0, query2); // GOOD // an integer from the user is injected into an SQL query. char query3[1000] = {0}; snprintf(query3, 1000, "SELECT UID FROM USERS where number = \"%i\"", userNumber); mysql_query(0, query3); // GOOD }