"""This is copied from ql/python/ql/test/library-tests/web/django/test.py and a only a slight extension of ql/python/ql/src/Security/CWE-089/examples/sql_injection.py """ from django.conf.urls import url from django.db import connection, models from django.db.models.expressions import RawSQL class User(models.Model): pass def show_user(request, username): with connection.cursor() as cursor: # GOOD -- Using parameters cursor.execute("SELECT * FROM users WHERE username = %s", username) User.objects.raw("SELECT * FROM users WHERE username = %s", (username,)) # BAD -- Using string formatting cursor.execute("SELECT * FROM users WHERE username = '%s'" % username) # BAD -- other ways of executing raw SQL code with string interpolation User.objects.annotate(RawSQL("insert into names_file ('name') values ('%s')" % username)) User.objects.raw("insert into names_file ('name') values ('%s')" % username) User.objects.extra("insert into names_file ('name') values ('%s')" % username) # BAD (but currently no custom query to find this) # # It is exposed to SQL injection (https://docs.djangoproject.com/en/2.2/ref/models/querysets/#extra) # For example, using name = "; DROP ALL TABLES -- " # will result in SQL: SELECT * FROM name WHERE name = ''; DROP ALL TABLES -- '' # # This shouldn't be very widespread, since using a normal string will result in invalid SQL # Using name = "example", will result in SQL: SELECT * FROM name WHERE name = ''example'' # which in MySQL will give a syntax error # # When testing this out locally, none of the queries worked against SQLite3, but I could use # the SQL injection against MySQL. User.objects.raw("SELECT * FROM users WHERE username = '%s'", (username,)) urlpatterns = [url(r'^users/(?P[^/]+)$', show_user)]