Rasmus Wriedt Larsen
1d25184b32
Python: Add test for type-tracking through decorators
...
In general, if there is _some_ decorator on a function, it might not be safe to
track content out of it (since the decorator could do anything), but in this
case, we can see what the decorator does, so we should be able to handle it (but
we don't right now).
By my understanding of how type-tracking works, if we track content through
`my_decorator`, then we would also track content to the result of
`unrelated_func()`, which I wanted to make sure our tests would catch.
I found out the core of the problem seems to come from our lack of being able to
track to the inner scope, and added an explicit test for that.
2021-02-09 13:43:10 +01:00
Rasmus Wriedt Larsen
eb7e30d472
Python: Add test of django view handler with decorator
...
Which we currently don't handle :(
Also added a bit more explanatory comments
2021-02-09 13:25:12 +01:00
Geoffrey White
d1910a3f5c
Update CONTRIBUTING.md
...
Co-authored-by: Jonas Jensen <jbj@github.com >
2021-02-09 12:12:24 +00:00
alexet
8dd5a7e7c7
Javascript Extractor: Update <tt> tages to <code>
2021-02-09 12:10:09 +00:00
Remco Vermeulen
3818971b79
Add redirect sinks
...
Both the familiy of `Accepted` and `Created` method set the location
header based on provided input. If this is untrusted input this can
result in an URL redirect attack.
2021-02-09 13:09:02 +01:00
Alexander Eyers-Taylor
bed10ad562
Merge pull request #5113 from github/alexet/fix-var-decls-spec
...
Update the language specification to allow empty var_decls
2021-02-09 11:08:23 +00:00
Rasmus Lerchedahl Petersen
e3002aa1bf
Python: model for sys.exc_info
...
made _easy_ by API graphs :D
2021-02-09 11:39:44 +01:00
Rasmus Lerchedahl Petersen
0ea2f457a1
Python: type trackers for exceptions
2021-02-09 11:39:44 +01:00
Rasmus Lerchedahl Petersen
232d9b006a
Python: Implement traceback module
...
Just functions, not the classes for now
2021-02-09 11:39:44 +01:00
Rasmus Lerchedahl Petersen
6a45f6e7e0
Python: Port StackTraceExposure query
...
using empty concept implementation
2021-02-09 11:12:44 +01:00
Rasmus Lerchedahl Petersen
77ae91c47d
Python: Add concept ExceptionSource
2021-02-09 11:12:44 +01:00
CaptainFreak
503b339a1f
remove hbs specific checks
2021-02-09 07:35:35 +05:30
Raul Garcia (MSFT)
f114ef1f06
Adding unit tests
2021-02-08 16:57:49 -08:00
Geoffrey White
8bf9fc6111
Consistent capitalisation.
2021-02-08 20:29:46 +00:00
Geoffrey White
07b263bb2f
Typo.
2021-02-08 20:27:28 +00:00
Geoffrey White
bd255617d8
Three copies of a link is too much.
2021-02-08 20:25:35 +00:00
Geoffrey White
e1ca762bbc
Fix layout.
2021-02-08 20:24:15 +00:00
Geoffrey White
65ea1a4631
Add hints / links about tests and documentation to CONTRIBUTING.md.
2021-02-08 20:04:10 +00:00
Geoffrey White
690b525192
Add a link to the C/C++ CodeQL Tests README.md from the Supported CodeQL queries and libraries doc.
2021-02-08 20:04:10 +00:00
Geoffrey White
74178a5e86
Call out the copied code issue for qhelp files again (more generally) in the Supported CodeQL queries and libraries doc.
2021-02-08 20:04:09 +00:00
Geoffrey White
cb16c64540
Call out the issue of copied code for C/C++ example code in the C/C++ CodeQL Tests README.md (where we talk about it for tests).
2021-02-08 19:58:36 +00:00
Alexander Eyers-Taylor
7583904046
Update the language specification to allow empty var_decls
...
This is a degenerate form that is accepted in the compiler even if they don't make much sense.
Fixes #5060
2021-02-08 18:54:13 +00:00
Taus Brock-Nannestad
c59b5c98cb
Python: Replace use of AttrNode with getMember
2021-02-08 19:14:11 +01:00
Taus Brock-Nannestad
72a699e099
Python: Add CallCfgNode class and rewrite using that class
...
I prefer this name to `CfgCallNode` as the latter will make
autocomplete more difficult.
2021-02-08 16:55:18 +01:00
Asger Feldthaus
b278233a94
JS: Mention all versions of Angular are supported
2021-02-08 15:45:46 +00:00
Taus Brock-Nannestad
46eb3fd10a
Python: Even more API::Node pushing.
2021-02-08 14:22:42 +01:00
Taus
c0c2aa69b3
Merge branch 'main' into python-port-flask-to-api-graphs
2021-02-08 14:17:25 +01:00
Taus Brock-Nannestad
2c4a477a4e
Python: Support moduleImport("dotted.name") in API graphs
2021-02-08 14:08:34 +01:00
Taus
738d1bc3d4
Python: More use of API::Node
...
Co-authored-by: yoff <lerchedahl@gmail.com >
2021-02-08 14:08:16 +01:00
haby0
97690b4eb7
Update java/ql/src/Security/CWE/CWE-652/XQueryInjection.qhelp
...
Co-authored-by: Felicity Chapman <felicitymay@github.com >
2021-02-08 19:15:28 +08:00
Tamas Vajk
bd50ed975f
Fix doc comment
2021-02-08 11:18:37 +01:00
CodeQL CI
8a2e063af7
Merge pull request #5107 from asgerf/js/json-in-script-tag
...
Approved by erik-krogh
codeql-cli/v2.4.4
2021-02-08 09:52:53 +00:00
Erik Krogh Kristensen
504db8739d
fix typo in execa change-note file name
2021-02-08 10:00:26 +01:00
Erik Krogh Kristensen
8ca75e41d2
add change note
2021-02-08 09:59:45 +01:00
intrigus
2e30f2d9ce
Java: Fix QHelp & accept test output
...
Accept test output for changed alert message.
2021-02-08 00:05:02 +01:00
Tamas Vajk
ef55ca179b
Improve file read exception logging
2021-02-07 09:06:11 +01:00
Tamas Vajk
6d908876e0
Add new .stats file
2021-02-07 09:06:11 +01:00
Tamas Vajk
96248f8845
Add DB upgrade folder
2021-02-07 09:06:11 +01:00
Tamas Vajk
63b0fe10e4
Rework foreach_stmt_info extraction
2021-02-07 09:06:11 +01:00
Tamas Vajk
7c506f445c
C#: Extract underlying methods of foreach statements
2021-02-07 09:06:11 +01:00
Jonas Jensen
7859c5234a
Merge pull request #5085 from geoffw0/msprintf2
...
C++: Fix FormattingFunction regression.
2021-02-06 16:06:35 +01:00
yoff
f1a0ec2dec
Merge pull request #4981 from RasmusWL/port-url-redirect-query
...
Python: Port url redirect query
2021-02-06 00:39:10 +01:00
yoff
ddd362bc16
Update python/ql/src/semmle/python/frameworks/Django.qll
...
Co-authored-by: Rasmus Wriedt Larsen <rasmuswl@github.com >
2021-02-05 23:31:20 +01:00
Raul Garcia (MSFT)
d775528069
Fixes on multiple files.
2021-02-05 14:09:26 -08:00
Asger Feldthaus
0ceb8aa638
JS: Bump extractor version
2021-02-05 21:55:43 +00:00
Asger Feldthaus
236b7c5887
JS: Tolerate JSON in script tags
2021-02-05 21:54:50 +00:00
Taus
d3a79ecff1
Update python/ql/src/semmle/python/frameworks/Flask.qll
...
Co-authored-by: yoff <lerchedahl@gmail.com >
2021-02-05 22:54:27 +01:00
Jonathan Leitschuh
f00b0baaea
Update java/ql/src/Security/CWE/CWE-1104/MavenPomDependsOnBintray.qhelp
...
Co-authored-by: intrigus-lgtm <60750685+intrigus-lgtm@users.noreply.github.com >
2021-02-05 16:31:37 -05:00
Taus Brock-Nannestad
3d2548ed28
Python: Get rid of remaining type trackers in Flask model
...
At this point, we may want to reconsider whether we really want the
deeply-nested module structure we had before (and which made the type
trackers somewhat bearable).
There's also a question of how we can make this a bit more
smooth. I think we need to consider exactly how we would like the
interface to this to work.
2021-02-05 21:58:08 +01:00
Taus Brock-Nannestad
5bfde2c0f2
Python: Fix overly broad class attribute node class
...
This is not strictly necessary, but it was bothering me that this
simply covered _all_ nodes that were both definitions and names at the
same time. Now it actually encompasses what the documentation claims
it does.
2021-02-05 21:56:57 +01:00