Commit Graph

19777 Commits

Author SHA1 Message Date
Jonas Jensen
d5e0357201 Revert "Revert "Version: Bump to 1.19.0 dev.""
This reverts commit ab2bec743a.
2018-09-05 21:07:19 +02:00
Jonas Jensen
ec626573c8 Merge pull request #161 from adityasharad/merge/1.18-master-050918
Merge rc/1.18 into master.
2018-09-05 20:54:14 +02:00
calum
3718237acc C#: Implement CFG for ConstCase statements with a condition. 2018-09-05 18:15:47 +01:00
calum
c2f3cb6a2a C#: Update analysis change notes. 2018-09-05 17:48:45 +01:00
calum
cff00506ba C#: Implementation of case ... when ...: which was not previously handled. Move getCondition to CaseStmt. Implement the CFG and tests. 2018-09-05 17:47:31 +01:00
calum
8c2d773866 C#: Extractor test for join ... into 2018-09-05 17:19:04 +01:00
calum
7a77740979 C#: Extractor tests for
- While statements
- Object initializers
2018-09-05 17:19:04 +01:00
calumgrant
727ab94c4e Merge pull request #140 from hvitved/csharp/cfg/renaming
C#: Rename and restructure control flow graph entities
2018-09-05 17:18:08 +01:00
Aditya Sharad
f27945216f Merge rc/1.18 into master. 2018-09-05 15:32:30 +01:00
Max Schaefer
8fbc191bf0 Merge pull request #160 from adityasharad/merge/1.18-next-050918
Merge rc/1.18 into next.
2018-09-05 15:15:23 +01:00
semmle-qlci
43e1e62d3a Merge pull request #133 from jbj/IRBlock-number-split
Approved by dave-bartolomeo
2018-09-05 14:58:15 +01:00
Aditya Sharad
cbdbda3723 Merge rc/1.18 into next. 2018-09-05 14:09:06 +01:00
semmle-qlci
a70526f79f Merge pull request #123 from jbj/primitive-bb-number-split
Approved by dave-bartolomeo
2018-09-05 13:21:14 +01:00
Tom Hvitved
061b3d40ea C#: Fix typos in change note 2018-09-05 14:20:27 +02:00
Tom Hvitved
82b2c00c19 C#: Add change note 2018-09-05 14:20:27 +02:00
Tom Hvitved
42faabc552 C#: Rename and restructure control flow graph entities
Follow a naming structure similar to the data flow library:

- `ControlFlowNode` -> `ControlFlow::Node`.
- `CallableEntryNode` -> `ControlFlow::Nodes::EntryNode`.
- `CallableExitNode` -> `ControlFlow::Nodes::ExitNode`.
- `ControlFlowEdgeType` -> `ControlFlow::SuccessorType`.
- `ControlFlowEdgeSuccessor` -> `ControlFlow::SuccessorTypes::NormalSuccessor`.
- `ControlFlowEdgeConditional -> ControlFlow::SuccessorTypes::ConditionalSuccessor`.
- `ControlFlowEdgeBoolean` -> `ControlFlow::SuccessorTypes::BooleanSuccessor`.
- `ControlFlowEdgeNullness` -> `ControlFlow::SuccessorTypes::NullnessSuccessor`.
- `ControlFlowEdgeMatching` -> `ControlFlow::SuccessorTypes::MatchingSuccessor`.
- `ControlFlowEdgeEmptiness` -> `ControlFlow::SuccessorTypes::EmptinessSuccessor`.
- `ControlFlowEdgeReturn` -> `ControlFlow::SuccessorTypes::ReturnSuccessor`.
- `ControlFlowEdgeBreak` -> `ControlFlow::SuccessorTypes::BreakSuccessor`.
- `ControlFlowEdgeContinue` -> `ControlFlow::SuccessorTypes::ContinueSuccessor`.
- `ControlFlowEdgeGotoLabel` -> `ControlFlow::SuccessorTypes::GotoLabelSuccessor`.
- `ControlFlowEdgeGotoCase` -> `ControlFlow::SuccessorTypes::GotoCaseSuccessor`.
- `ControlFlowEdgeGotoDefault` -> `ControlFlow::SuccessorTypes::GotoDefaultSuccessor`.
- `ControlFlowEdgeException` -> `ControlFlow::SuccessorTypes::ExceptionSuccessor`
2018-09-05 14:20:26 +02:00
calumgrant
8263b248b7 Merge pull request #152 from hvitved/csharp/base-ssa
C#: Fix bug in BaseSsa library
2018-09-05 13:02:56 +01:00
semmle-qlci
5fcd663e9f Merge pull request #158 from esben-semmle/js/sharpen-regexp-injection
Approved by xiemaisi
2018-09-05 12:45:59 +01:00
Ian Lynagh
ca082be371 C++: Fix spurious extra qualified names for enum constants within a class 2018-09-05 12:29:43 +01:00
Ian Lynagh
c204ec3a8f C++: Enhance qualifiers/class-enum test 2018-09-05 12:28:57 +01:00
semmle-qlci
50b5a3bd71 Merge pull request #151 from asger-semmle/ts-ambient-toplevel
Approved by xiemaisi
2018-09-05 10:52:08 +01:00
semmle-qlci
6c1098d170 Merge pull request #120 from hvitved/csharp/query/useless-upcast
Approved by calumgrant
2018-09-05 08:39:25 +01:00
Esben Sparre Andreasen
f63a3b3f39 JS: add missing abstract modifier 2018-09-05 09:20:45 +02:00
Esben Sparre Andreasen
6e1846b1ca JS: address doc review comments 2018-09-05 09:20:45 +02:00
Esben Sparre Andreasen
89887e7dc8 JS: address review comments 2018-09-05 09:20:45 +02:00
Esben Sparre Andreasen
2306afdebf JS: use extensible architecture for Electron- and NodeClientRequest 2018-09-05 09:20:45 +02:00
Esben Sparre Andreasen
2dd8e95a51 JS: remove unused getOptions method 2018-09-05 09:20:45 +02:00
Esben Sparre Andreasen
d578c7422d JS: docstring cleanup 2018-09-05 09:20:45 +02:00
Esben Sparre Andreasen
0da14fccbd JS: renaming UrlRequests.qll -> ClientRequests.qll 2018-09-05 09:20:45 +02:00
Esben Sparre Andreasen
6d78350fee JS: s/URLRequest/ClientRequest, merge with NodeJSLib::ClientRequest 2018-09-05 09:20:45 +02:00
Jonas Jensen
e0c073360b C++: Remove CP in getOperandMemoryAccess
The overrides of `Instruction.getOperandMemoryAccess` did not relate
`this` to any of its other parameters, which made it attempt to compute
the Cartesian product of `Instruction` and `TPhiOperand`. This happened
only during computation of aliased SSA. Perhaps the optimizer was able
to eliminate the CP for the non-aliased SSA computation.

With this change, I'm able to compute aliased SSA for medium-sized
snapshots.
2018-09-05 08:52:39 +02:00
Jonas Jensen
5541b9fbf1 C++: Split IRBlock index from IRBlock membership
Instead of computing these two things in one predicate, they are
computed in separate predicates and then joined. This splits the
predicate `getInstruction`, which took 81s before, into predicates that
together take 20s on a medium-sized db.
2018-09-05 08:50:36 +02:00
Jonas Jensen
1bcae97447 Merge pull request #114 from geoffw0/samate-realloc
CPP: Handle 'realloc' better in MemoryMayNotBeFreed.ql
2018-09-05 08:35:13 +02:00
Esben Sparre Andreasen
b9d825b379 JS: better matching of String.prototype.search in js/regex-injection 2018-09-05 08:35:00 +02:00
semmle-qlci
a46df8e0a2 Merge pull request #154 from jbj/mergeback-master-20180904
Approved by adityasharad
2018-09-05 07:21:00 +01:00
semmle-qlci
8225daf94d Merge pull request #122 from dave-bartolomeo/dave/IRShuffle
Approved by jbj
2018-09-04 23:56:38 +01:00
semmle-qlci
2d4f664be8 Merge pull request #157 from ian-semmle/declarationName
Approved by jbj
2018-09-04 23:08:27 +01:00
Nick Rolfe
ccceef30e6 Merge pull request #155 from adityasharad/revert/master/version-1.19.0
Revert "Version: Bump to 1.19.0 dev."
2018-09-04 21:16:43 +01:00
Jonas Jensen
43704e2f0d Merge pull request #144 from ian-semmle/topLevel2
C++: Improve GlobalNamespace.getADeclaration()
2018-09-04 20:22:22 +02:00
semmle-qlci
20ade48975 Merge pull request #146 from ian-semmle/TemplateParameterName
Approved by jbj
2018-09-04 19:16:55 +01:00
Tom Hvitved
124a00ba10 C#: Update expected output in SSA tests 2018-09-04 20:15:33 +02:00
Ian Lynagh
ce5653a2f6 C++: Tweak qldoc for declaration names 2018-09-04 19:14:16 +01:00
Dave Bartolomeo
4a1d04b423 C++: Fix deprecated predicate warnings 2018-09-04 10:30:48 -07:00
Geoffrey White
ae80b8dbec Merge pull request #145 from nickrolfe/rewording
C++: clearer alert wording in integer-multiplication-cast-to-long
2018-09-04 18:00:37 +01:00
Geoffrey White
71483c7025 CPP: Remove some empty source files. 2018-09-04 17:51:46 +01:00
Dave Bartolomeo
4086a8909b C++: Fix a couple IR-related tests to handle new directory tree
Also moved those tests under the IR test directory, so I'm less likely to forget them next time.
2018-09-04 09:05:33 -07:00
Dave Bartolomeo
fce7a5fccb C++: Final IR reshuffle
Moved IR flavors into "implementation", with internal files under "implementation/internal". Made `IRBlockConstruction` just a nested module of `IRConstruction`/`SSAConstruction`, so it gets picked up from the `Construction` parameter of the `IR` module, rather than being picked up just from being in the same directory as `IRBlock`.
2018-09-04 09:05:27 -07:00
Dave Bartolomeo
aa4436fa22 C++: More IR reshuffling
Remove redundant "_ir" suffix.
Move non-user-importable modules into "implementation" directory.
2018-09-04 09:05:21 -07:00
Dave Bartolomeo
97cfbd9488 C++: "IR" means "Aliased SSA IR"
This change makes the public IR.qll module resolve to the flavor of the IR that we want queries to use. Today, this is the aliased SSA flavor of the IR. Should we add additional IR iterations in the future, we'll update IR.qll to resolve to whichever one we consider the default.

I moved the PrintIR.ql and IRSanity.ql queries into the internal directories of the corresponding flavors. There's still a PrintIR.ql and an IRSanity.ql in the public IR directory, which use the same IR flavor as the public IR.qll.
2018-09-04 09:05:15 -07:00
Dave Bartolomeo
9fd5f26e2e C++: Remove unnecessary Impl suffix from some files 2018-09-04 09:05:10 -07:00