Asger F
ef79023e52
Update javascript/ql/src/Expressions/MissingAwait.qhelp
...
Co-Authored-By: Max Schaefer <54907921+max-schaefer@users.noreply.github.com >
2020-01-08 10:23:30 +00:00
Tom Hvitved
85f6e5fe22
Merge pull request #2450 from calumgrant/cs/expr-nullability
...
C#: Expression nullability
2020-01-08 09:50:03 +01:00
Mathias Vorreiter Pedersen
100ace532f
C++: Fixed handling of false negative. Query now supports global variables
2020-01-07 22:57:21 +01:00
Mathias Vorreiter Pedersen
db08076fed
C++: Fixed false negative
2020-01-07 22:20:04 +01:00
Mathias Vorreiter Pedersen
229da0a9c0
C++: Add testcase demonstrating false negative
2020-01-07 22:12:34 +01:00
Dave Bartolomeo
690d23d15e
C++: Fix formatting
2020-01-07 13:23:36 -07:00
Dave Bartolomeo
9df37399f8
C++: Consolidate opcode properties onto Opcode class
...
Previously, we had several predicates on `Instruction` and `Operand` whose values were determined solely by the opcode of the instruction. For large snapshots, this meant that we would populate large tables mapping each of the millions of `Instruction`s to the appropriate value, times three (once for each IR flavor).
This change moves all of these opcode properties onto `Opcode` itself, with inline wrapper predicates on `Instruction` and `Operand` where necessary. On smaller snapshots, like ChakraCore, performance is a wash, but this did speed up Wireshark by about 4%.
Even ignoring the modest performance benefit, having these properties defined on `Opcode` seems like a better organization than having them on `Instruction` and `Operand`.
2020-01-07 13:17:27 -07:00
Calum Grant
bc1b2c3ead
C#: Address review comment
2020-01-07 18:39:52 +00:00
Calum Grant
d0d7ed620c
C#: Update comments in test file to reflect fixed test output.
2020-01-07 18:39:52 +00:00
Calum Grant
359dea2c2b
C#: Fixed test output.
2020-01-07 18:39:52 +00:00
Calum Grant
bcd8dca780
C#: When creating conditionally accessed expressions, use the typeinfo from the conditional expression to ensure correct flow state and type nullability.
2020-01-07 18:39:51 +00:00
Calum Grant
85c9459b35
C#: Add more tests showing incorrect extraction.
2020-01-07 18:39:51 +00:00
Calum Grant
10181e93e2
C#: Update QLtest output
2020-01-07 18:39:51 +00:00
Calum Grant
a1bedf2e06
C#: Use expression flow state to determine non-null guards
2020-01-07 18:39:51 +00:00
Calum Grant
2eb29224e8
C#: Update guards tests.
2020-01-07 18:39:51 +00:00
Calum Grant
ecb22f1379
C#: Fix typo in dbscheme.
2020-01-07 18:39:51 +00:00
Calum Grant
f67240a316
C#: Analysis change notes
2020-01-07 18:39:51 +00:00
Calum Grant
1036640e24
C#: Update db stats
2020-01-07 18:38:58 +00:00
Calum Grant
4e710e9685
C#: DB upgrade script
2020-01-07 18:38:58 +00:00
Calum Grant
8db46bc8ec
C#: More tests for nullable flow state.
2020-01-07 18:38:58 +00:00
Calum Grant
6c9ebaba0b
C#: Populate expression type nullability and nullable flow state.
2020-01-07 18:38:58 +00:00
Calum Grant
0327b83958
C#: Update nullability tests.
2020-01-07 18:38:58 +00:00
Dave Bartolomeo
3072e9c7da
Merge pull request #2598 from geoffw0/av114_asm
...
CPP: Exclude functions containing asm from cpp/missing-return
2020-01-07 09:04:14 -07:00
Mathias Vorreiter Pedersen
633c42ced0
C++: Removed comment
2020-01-07 14:41:37 +01:00
Anders Schack-Mulligen
d918cb1f6f
Merge pull request #2550 from JLLeitschuh/task/JLL/improve_netty_response_splitting_detection
...
Add io.netty.handler.codec.http.DefaultHttpResponse to Netty Response Splitting Detection
2020-01-07 14:28:01 +01:00
Mathias Vorreiter Pedersen
d9f931da3c
C++: Fix false positives
2020-01-07 14:16:50 +01:00
Mathias Vorreiter Pedersen
6bbe2c48bf
C++: Add testcase demonstrating false positive
2020-01-07 14:13:34 +01:00
Geoffrey White
c584ceb2f4
CPP: Change note.
2020-01-07 12:46:07 +00:00
Geoffrey White
72b4792391
CPP: Exception for AsmStmts.
2020-01-07 12:46:07 +00:00
Geoffrey White
0a85637fef
CPP: Add a test.
2020-01-07 12:46:07 +00:00
Mathias Vorreiter Pedersen
9a841636dc
C++: Fix false positive
2020-01-07 13:22:07 +01:00
Mathias Vorreiter Pedersen
faa9d83567
C++: Add testcase demonstrating false positive
2020-01-07 13:18:38 +01:00
Mathias Vorreiter Pedersen
bdd0589223
C++: Fix false positive
2020-01-07 13:16:47 +01:00
Calum Grant
d8f5450b67
C#: Alert suppression comments can be in C89-style comments
2020-01-07 11:52:52 +00:00
Mathias Vorreiter Pedersen
428e357488
C++: Add testcase demonstrating false positive
2020-01-07 11:41:48 +01:00
semmle-qlci
0e16969e15
Merge pull request #2591 from max-schaefer/js/fix-16
...
Approved by asgerf
2020-01-07 10:36:19 +00:00
Asger Feldthaus
d55d5cc4ed
JS: Address comments from doc review
2020-01-07 10:27:46 +00:00
Asger Feldthaus
66a16d21a9
JS: Fix buggy test cases
2020-01-07 10:19:09 +00:00
Asger Feldthaus
2d534163d0
JS: Add test for empty regex
2020-01-07 10:10:29 +00:00
Asger Feldthaus
9f6e04887b
JS: Fix FP from word boundaries
2020-01-07 10:09:17 +00:00
Tom Hvitved
5552c2e912
Merge pull request #2563 from calumgrant/cs/tuple-expr
...
C#: Handle tuple expressions
2020-01-07 09:31:17 +01:00
Robert Marsh
367d13c0ad
Merge pull request #2570 from jbj/ir-overlappingVariableMemoryLocations
...
C++: Fix overlappingVariableMemoryLocations perf
2020-01-06 10:57:48 -08:00
Robert Marsh
ba9741f552
C++: compute overlap on irvars with vvar indexes
2020-01-06 09:14:03 -08:00
Anders Schack-Mulligen
9ba169b346
Java: Fix bad join-order.
2020-01-06 16:52:06 +01:00
Calum Grant
c145e32625
C#: Tests for multiline alert suppression comments
2020-01-06 15:45:00 +00:00
Asger F
b604be5cfb
Apply suggestions from code review
...
Co-Authored-By: Max Schaefer <54907921+max-schaefer@users.noreply.github.com >
2020-01-06 14:44:02 +00:00
Asger Feldthaus
4c25d84b6e
JS: Fix and expand test cases
2020-01-06 14:43:29 +00:00
Tom Hvitved
ed2125969e
Merge pull request #2568 from calumgrant/cs/assignment-to-_
...
C#: Remove FP in useless assignment to _
2020-01-06 15:39:45 +01:00
Max Schaefer
9160fbf106
Merge pull request #2435 from asger-semmle/phi-edge-barrier-guards
...
JS: Phi edge barrier guards
2020-01-06 14:14:18 +00:00
semmle-qlci
f48e4bc2a0
Merge pull request #2580 from asger-semmle/typescript-unbounded-recursion
...
Approved by max-schaefer
2020-01-06 14:00:55 +00:00